From: David Woodhouse <dwmw2@infradead.org>
To: rob@sysgo.de
Cc: mtd@infradead.org
Subject: Re: Swich statement in cfi_probe.c
Date: Mon, 12 Mar 2001 17:27:10 +0000 [thread overview]
Message-ID: <27977.984418030@redhat.com> (raw)
In-Reply-To: <01031218235800.02378@rob>
rob@sysgo.de said:
> I noticed that in cfi_probe.c, routine cfi_probe_new_chip(), the
> cases following the switch(map->buswidth) are not terminated by a
> break. Thus if the probe fails for the given buswidth, the code will
> try all remaining buswidths too.
> Is that a bug or does it serve a purpose (if so, which ?)
Not sure. If it has a purpose, the only possibility I can think of off the
top of my head is to work around people giving the wrong buswidth. And I
think the code would probably break then anyway.
So it's probably a bug. If nobody shouts I'll add in the missing breaks.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
prev parent reply other threads:[~2001-03-12 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-12 17:15 Swich statement in cfi_probe.c Robert Kaiser
2001-03-12 17:27 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27977.984418030@redhat.com \
--to=dwmw2@infradead.org \
--cc=mtd@infradead.org \
--cc=rob@sysgo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.