Re: [PATCH v2 1/1] dt-bindings: fsl: fsl, rcpm: Add #power-domain-cells

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi Frank,

Am Freitag, 1. August 2025, 01:36:42 CEST schrieb Frank Li:
> On Thu, Jul 31, 2025 at 08:32:57AM +0200, Krzysztof Kozlowski wrote:
> > On Thu, Jul 31, 2025 at 07:58:04AM +0200, Alexander Stein wrote:
> > > dtbs_check for ls1021.dtsi warns about unsupported property:
> > >  power-controller@1ee2140 (fsl,ls1021a-rcpm): '#power-domain-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > >
> > > But if removed the check warns about missing property:
> > >  power-controller@1ee2140 (fsl,ls1021a-rcpm): '#power-domain-cells' is a required property
> >
> >
> > And if any other warning says something, are you going to do that as
> > well?
> >
> > >
> > > Given commit 8bcf67b8d893b ("ARM: dts: ls1021a: add #power-domain-cells
> > > for power-controller node") explicitly added that property, add it
> > > to the expected property list as well.
> >
> > No, commit does not explain why! It's one of this NXP commits without
> > explanation, doing random things.
> >
> > No, explain why do you think this is a power domain provider - fast
> > look told me that it is NOT.
> 
> It is not power controller. rcpm controller enable wakeup source.
> 
> In arm64, use below patch to fix warning
> 
> commit e39f567e1c38c29629962ab327f0ad1a288dcab2
> Author: Frank Li <Frank.Li@nxp.com>
> Date:   Mon Jul 29 14:59:24 2024 -0400
> 
>     arm64: dts: layerscape: rename rcpm as wakeup-control from power-control
> 
>     Invoke power-domain.yaml if node name as 'power-control'.
> 
>     Rcpm actually are not power domain controller. It just control wakeup
>     capability. So rename it as wakeup-control. Fix below CHECK_DTBS warning.
> 
>     power-controller@1ee2140: '#power-domain-cells' is a required property
>             from schema $id: http://devicetree.org/schemas/power/power-domain.yaml#
> 
>     Signed-off-by: Frank Li <Frank.Li@nxp.com>
>     Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> 

Thanks for the link. I've applied a similar change to ls1021 instead of this patch.

Thanks and best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/