From: "David Wang" <00107082@163.com>
To: "Donald Hunter" <donald.hunter@gmail.com>
Cc: fw@strlen.de, "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER
Date: Tue, 5 Sep 2023 18:57:15 +0800 (CST) [thread overview]
Message-ID: <279bb09e.54ab.18a64fd47e8.Coremail.00107082@163.com> (raw)
In-Reply-To: <m28r9ldm7d.fsf@gmail.com>
At 2023-09-05 17:05:26, "Donald Hunter" <donald.hunter@gmail.com> wrote:
>David Wang <00107082@163.com> writes:
>
>> This sample code implements a simple ipv4
>> blacklist via the new bpf type BPF_PROG_TYPE_NETFILTER,
>> which was introduced in 6.4.
>>
>> The bpf program drops package if destination ip address
>> hits a match in the map of type BPF_MAP_TYPE_LPM_TRIE,
>>
>> The userspace code would load the bpf program,
>> attach it to netfilter's FORWARD/OUTPUT hook,
>> and then write ip patterns into the bpf map.
>>
>> Signed-off-by: David Wang <00107082@163.com>
>> ---
>> samples/bpf/Makefile | 3 +
>> samples/bpf/netfilter_ip4_blacklist.bpf.c | 62 +++++++++++++++
>> samples/bpf/netfilter_ip4_blacklist.c | 96 +++++++++++++++++++++++
>> 3 files changed, 161 insertions(+)
>> create mode 100644 samples/bpf/netfilter_ip4_blacklist.bpf.c
>> create mode 100644 samples/bpf/netfilter_ip4_blacklist.c
>
>According to https://docs.kernel.org/process/coding-style.html#naming
>you should avoid new use of blacklist. You should use somethink like
>denylist or blocklist instead.
Thanks for the information~!
I will make the changes, and resend a patch if samples/bpf is still a good place to put the code.
prev parent reply other threads:[~2023-09-05 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 10:21 [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER David Wang
2023-09-04 10:48 ` Florian Westphal
2023-09-04 11:10 ` David Wang
2023-09-04 11:29 ` David Wang
2023-09-04 21:01 ` [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE_NETFILTER Alexei Starovoitov
2023-09-05 3:16 ` David Wang
2023-09-05 8:41 ` Toke Høiland-Jørgensen
2023-09-05 10:52 ` David Wang
2023-09-05 11:09 ` David Wang
2023-09-05 15:49 ` Alexei Starovoitov
2023-09-05 16:06 ` David Wang
2023-09-05 9:05 ` Donald Hunter
2023-09-05 10:57 ` David Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279bb09e.54ab.18a64fd47e8.Coremail.00107082@163.com \
--to=00107082@163.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=donald.hunter@gmail.com \
--cc=fw@strlen.de \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.