From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AAE7C52D7C for ; Fri, 23 Aug 2024 10:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IUm55HmBdVUnY7b9nUrFMCCp2nXDS0fD0wUC/TvFhmQ=; b=ITo3d4HmBRQ4yJB4UX7gtmCSOk GZJowE8snXThL8uKeDwv75R7MZyymzXzmARI2fSP5guGTC5iRjXYJYkJgmsCz/iy/ex8W2UqALG2P aaLgW+jkDsvwcD0iwG5RkQZZFFjSWa1iyxQ/0XVzqaqUF1Pi+5VqyeQ+B37HgiJDKMgGvlUy0jlGN 7PLIa7mRIrld+Z9c/qJFvz7799kYicMZ3DG98aac6G49jiqiL5PCcyjzi6Jd5k2pnLcXbnbiw0TEq UIDk1M+ZJ7RhHMd/fkm01K3fAdTcmtPdPNkwVfNS2uQoW7oNpFGQuPLKKk7yrALEDz9P7OzD1Amg8 8twAoxcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shRf8-0000000GMkJ-03tN; Fri, 23 Aug 2024 10:36:58 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shReL-0000000GMd8-0Ib7 for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 10:36:11 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4281d812d3eso18217875e9.3 for ; Fri, 23 Aug 2024 03:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724409367; x=1725014167; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IUm55HmBdVUnY7b9nUrFMCCp2nXDS0fD0wUC/TvFhmQ=; b=qtV8I+cWMFmzUTsJOUu4sCYkUNNE3lwpCyznNW2MosUnzVvGq+WPj0lvF2vnB6jNDG HTL5cZlVE/6RWE60SpRPbovz1xbDwaXkKiC82fBJmA5UAUC7psrRHElCC3PKs63xJHoS zC5pdOdjLXPjZQPpaddrHGdDKReyjm/c1pIW9jlxzUQxgekP+cX4B8bFpzAf2LONzjXT VEtU6/DTUdcC+zQWEOD3J6OR32iTLJnk4jLMzCJIge/yh7qyRWxetgH/Bf8+ofMtYy6O 2TweDT1cKNrrmp5DSpQiUqjmUBZezdTBFsv3fH4u8RIv/WSPKs2EyX5hl0jSnv1Yw7SL rY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724409367; x=1725014167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IUm55HmBdVUnY7b9nUrFMCCp2nXDS0fD0wUC/TvFhmQ=; b=ilVBbPmckgJsd4K4VjTNYxXJ90Qa7XgG2wQQqIh44ZFQRIQVQbzPvw7ne0tITD8172 IXi3q+Re4gEwIbkpLKl/k3j/oaHuksPtvjgIouQa/Nm4HXyu4MNmXhCfvAOmDo4Wpa0Y r0ioB6L39/bz2mokNLEsYJkr6cvs0uOIyYG7CvWYQn2BgulolDU4hoW33nB8j37fSz/x YvK3oZaSiY7jcGi0h0AbNmeFRwQdoC0+nEWtuEmi5kxs50kAh8KG8XQ/GR76fNKcor9L nUBvll1ak/yDvIWPpHSHAY+z2I6Is+D21YFcPGdTNKz5XJyYZ4BpWPru+lFgc/XI89ej ZYEA== X-Forwarded-Encrypted: i=1; AJvYcCXlLGAl4zHLsnwONN4owLQP8P+ykurA7u0Ft3s7GZg58H6A4+uy07WB9lsCqbc7oR5HVf9bGdznFCXVKlbQm0cr@lists.infradead.org X-Gm-Message-State: AOJu0Yx8dl4LlmKMkXjYRIL8kE4dF0DO1PByvGnuiWtTd0/cSlM6HSdr dVosEyuIpa22xJHuUDyzwoqCrQd/N/Ve1XUYKlTjSyutL6/RIhx+qHJuJCHawK1+iPg5fY2+JrK Y664= X-Google-Smtp-Source: AGHT+IHpGlL/vZl9Dn7OIltdnzyiefDa8zo2GYYa+LdqkDj+I6KNwURS7lUt3mMhSS4BKRkBmLrU6Q== X-Received: by 2002:a5d:4a0b:0:b0:371:890c:891a with SMTP id ffacd0b85a97d-37311840111mr1379574f8f.8.1724409366981; Fri, 23 Aug 2024 03:36:06 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f2e74bbsm242549366b.95.2024.08.23.03.36.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 03:36:06 -0700 (PDT) Message-ID: <279c7fae-efff-477e-8649-ff7f6d42dd87@linaro.org> Date: Fri, 23 Aug 2024 11:36:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf scripts python arm-cs-trace-disasm.py: Skip disasm if address continuity is broken To: Ganapatrao Kulkarni , Mike Leach Cc: Leo Yan , scclevenger@os.amperecomputing.com, acme@redhat.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, darren@os.amperecomputing.com, james.clark@arm.com, suzuki.poulose@arm.com, Al.Grant@arm.com References: <20240719092619.274730-1-gankulkarni@os.amperecomputing.com> <00fac24c-d664-4ebb-8c60-f4697b7f76c1@linaro.org> <8b53a424-19f7-4042-a2db-e1c5d051f9cc@os.amperecomputing.com> <6adf84fa-b755-4d7a-957a-9bf01e442238@linaro.org> <6f535bb6-2cee-48e6-93f1-ea19887bae74@os.amperecomputing.com> <027c76a9-9bd4-43e9-a170-8391a0037291@linaro.org> <3d7a6f93-0555-48fa-99cb-bf26b53c2da5@os.amperecomputing.com> <4dd7f210-c03e-4203-b8e9-1c26a7f8fe79@arm.com> <27912fc6-8419-4828-82a7-dacde5b4a759@linaro.org> <36f947ef-c2a7-486a-b905-f0529308b06e@linaro.org> <51661f76-c02a-49fb-8d68-53a8549acd19@os.amperecomputing.com> Content-Language: en-US From: James Clark In-Reply-To: <51661f76-c02a-49fb-8d68-53a8549acd19@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_033609_187061_89137C37 X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/08/2024 10:57 am, Ganapatrao Kulkarni wrote: > > Hi James/Mike, > > On 23-08-2024 02:33 pm, James Clark wrote: >> >> >> On 19/08/2024 11:59 am, Mike Leach wrote: >>> Hi, >>> >>> A new branch of OpenCSD is available - ocsd-consistency-checks-1.5.4-rc1 >>> >>> Testing I managed to do confirms the N atom on unconditional branches >>> appear to work. I do not have a test case for the range >>> discontinuities. >>> >>> The checks are enabled using operation flags on decoder creation. See >>> the docs for details. >>> >>> Mike >>> >> >> Hi Mike, >> >> I tested the new OpenCSD and I don't see the error anymore in the >> disassembly script. I'm not sure if we need to go any further and add >> the backwards check, it looks like just a later symptom and the checks >> that you've added already prevent it. >> >> If you release a new version I can send the perf patch. I was going to >> use these flags if that looks right to you? As far as I know that's the >> set that can be always on and won't fail on bad hardware? >> >> I also assumed that ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK can be given even >> for etmv3 and it's just a nop? >> >> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >> index e917985bbbe6..90967fd807e6 100644 >> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c >> @@ -685,9 +685,14 @@ cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, >>                  return 0; >> >>          if (d_params->operation == CS_ETM_OPERATION_DECODE) { >> +               int decode_flags = OCSD_CREATE_FLG_FULL_DECODER; >> +#ifdef OCSD_OPFLG_N_UNCOND_DIR_BR_CHK >> +               decode_flags |= OCSD_OPFLG_N_UNCOND_DIR_BR_CHK | OCSD_OPFLG_CHK_RANGE_CONTINUE | >> +                               ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK; >> +#endif >>                  if (ocsd_dt_create_decoder(decoder->dcd_tree, >>                                             decoder->decoder_name, >> -                                          OCSD_CREATE_FLG_FULL_DECODER, >> +                                          decode_flags, >>                                             trace_config, &csid)) >>                          return -1; >> > > I tried Mike's branch with above James's patch and still the segfault is happening to us. > Did you update OpenCSD as well?