Re: [PATCH v8 10/10] docs/system: virtio-gpu: Document host/guest requirements

[Dmitry Osipenko <dmitry.osipenko@collabora.com>]

On 2/13/25 07:47, Akihiko Odaki wrote:
> On 2025/02/10 1:56, Dmitry Osipenko wrote:
>> From: Alex Bennée <alex.bennee@linaro.org>
>>
>> This attempts to tidy up the VirtIO GPU documentation to make the list
>> of requirements clearer. There are still a lot of moving parts and the
>> distros have some catching up to do before this is all handled
>> automatically.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Sergio Lopez Pascual <slp@redhat.com>
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> [dmitry.osipenko@collabora.com: Extended and corrected doc]
>> ---
>>   docs/system/devices/virtio-gpu.rst | 106 ++++++++++++++++++++++++++++-
>>   1 file changed, 104 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/
>> virtio-gpu.rst
>> index ea3eb052df3c..664fc4000fa9 100644
>> --- a/docs/system/devices/virtio-gpu.rst
>> +++ b/docs/system/devices/virtio-gpu.rst
>> @@ -5,14 +5,34 @@ virtio-gpu
>>   ==========
>>     This document explains the setup and usage of the virtio-gpu device.
>> -The virtio-gpu device paravirtualizes the GPU and display controller.
>> +The virtio-gpu device provides a GPU and display controller
>> +paravirtualized using VirtIO. It supports a number of different modes
>> +from simple 2D displays to fully accelerated 3D graphics.
>> +
>> +virtio-gpu requirements
>> +-----------------------
>>     Linux kernel support
>> ---------------------
>> +^^^^^^^^^^^^^^^^^^^^
>>     virtio-gpu requires a guest Linux kernel built with the
>>   ``CONFIG_DRM_VIRTIO_GPU`` option.
>>   +Host Linux kernel requirements vary depending on a used virtio-gpu
>> +capabilities. See further sections for a detailed descriptions.
> 
> The section for 3D acceleration follows so let's defer the description
> for the host requirements to that section.
> 
> Perhaps the section title may be changed to clarify that it only
> describes the guest Linux kernel requirement to exclude the host Linux
> kernel requirement as well as guest Mesa.

Alright, think I now see what you meant in the comment to v7.

>> +.. list-table:: Linux Host Requirements
>> +  :header-rows: 1
>> +
>> +  * - Capability
>> +    - Kernel
>> +    - Rutabaga build flags
>> +  * - Vulkan+Wayland pass-through
>> +    - Linux 6.13+
>> +    - Follow `gfxstream-enabled rutabaga`_ build instructions
> 
> It is odd that the column header says "build flags", and this cell says
> "Follow `gfxstream-enabled rutabaga`_ build instructions".
> 
> I think you can simply remove this column. This section already says it
> leverages Rutabaga and the crosvm book provides build instructions.

In the other reply you said that you're strongly opposed to adding any
Mesa/virglrenderer build flags to the QEMU doc. I'm going to remove all
build flags in v9. Please let me know if I misunderstood you and you're
meaning something else.

-- 
Best regards,
Dmitry