Re: [PATCH v4] pmd/snow3g: add new SNOW 3G SW PMD

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-03-10 16:33, Pablo de Lara:
> +SNOW 3G PMD
> +M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> +F: drivers/crypto/snow3g

Missing doc reference:
F: doc/guides/cryptodevs/snow3g.rst

> +To build DPDK with the SNOW3G_PMD the user is required to get
> +the export controlled libsso library, sending a request to
> +`DPDKUser_software_access@intel.com`, and compile it
> +on their user system before building DPDK:

I'm a bit concerned that this library is not freely available.
It makes testing difficult.

> +The environmental variable LIBSSO_PATH must be exported with the path
> +where you extracted and built the libsso library and finally set
> +CONFIG_RTE_LIBRTE_SNOW3G=y in config/common_base.

It is CONFIG_RTE_LIBRTE_PMD_SNOW3G.

> +# SNOW3G PMD is dependent on the LIBSSO library
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G)     += -lrte_pmd_snow3g
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G)     += -L$(LIBSSO_PATH)/build -lsso
> +
>  endif # ! $(CONFIG_RTE_BUILD_SHARED_LIB)

This is for the static library case.
The PMD should be linked to libsso also in the shared library case.
There is the same problem with -lIPSec_MB (aesni_mb driver).