All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avinesh Kumar <akumar@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] tst_test.sh: Fix IPC init for checkpoints
Date: Fri, 27 Jun 2025 21:38:23 +0200	[thread overview]
Message-ID: <2803405.mvXUDI8C0e@thinkpad> (raw)
In-Reply-To: <20250627102957.4165-2-chrubis@suse.cz>

Hi,

Tested-by: Avinesh Kumar <akumar@suse.de>

cn_pec 1 TINFO: Running: cn_pec.sh 
cn_pec 1 TINFO: Tested kernel: Linux susetest 6.15.3-1-default #1 SMP PREEMPT_DYNAMIC Sat Jun 21 19:19:18 UTC 2025 (d7f7d34) x86_64 x86_64 x86_64 GNU/Linux
cn_pec 1 TINFO: Using /tmp/LTP_cn_pec.Gsup5b4iUP as tmpdir (tmpfs filesystem)
cn_pec 1 TINFO: timeout per run is 0h 5m 0s
cn_pec 1 TINFO: Test process events connector
cn_pec 1 TINFO: Testing fork event (nevents=10)
cn_pec 1 TPASS: All events detected
cn_pec 2 TINFO: Testing exec event (nevents=10)
cn_pec 2 TPASS: All events detected
cn_pec 3 TINFO: Testing exit event (nevents=10)
cn_pec 3 TPASS: All events detected
cn_pec 4 TINFO: Testing uid event (nevents=10)
cn_pec 4 TPASS: All events detected
cn_pec 5 TINFO: Testing gid event (nevents=10)
cn_pec 5 TPASS: All events detected


Regards,
Avinesh

On Friday, June 27, 2025 12:29:57 PM CEST Cyril Hrubis wrote:
> The introduction of magic at the start of the LTP IPC region did break
> the checkpoints for the tst_test.sh shell library. The reason is that
> the library creates the IPC backing file with dd and the magic wasn't
> present there.
> 
> This introduced failures in the pec testcases:
> 
>   cn_pec 1 TINFO: Test process events connector
>   cn_pec 1 TINFO: Testing fork event (nevents=10)
>   tst_test.c:203: TBROK: Invalid shared memory region (bad magic)
>   cn_pec 1 TBROK: tst_checkpoint wait 10000 0 failed
> 
> This patch fixes the tst_test.sh library so that the IPC region is
> created with a correct magic.
> 
> Follow-up: bf9589d5bd ("lib: moves test infrastructure states into a shared context structure")
> Reported-by: Avinesh Kumar <akumar@suse.de>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  testcases/lib/tst_test.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> index c32bd8b19..4be10a4f9 100644
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -627,6 +627,7 @@ _tst_init_checkpoints()
>  		tst_brk TBROK "tst_getconf PAGESIZE failed"
>  	fi
>  	ROD_SILENT dd if=/dev/zero of="$LTP_IPC_PATH" bs="$pagesize" count=1
> +	ROD_SILENT "printf LTPM | dd of="$LTP_IPC_PATH" bs=1 seek=0 conv=notrunc"
>  	ROD_SILENT chmod 600 "$LTP_IPC_PATH"
>  	export LTP_IPC_PATH
>  }
> 





-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-06-27 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 10:29 [LTP] [PATCH 1/2] lib: tst_test: Make IPC magic spells 'LTPM' Cyril Hrubis
2025-06-27 10:29 ` [LTP] [PATCH 2/2] tst_test.sh: Fix IPC init for checkpoints Cyril Hrubis
2025-06-27 19:38   ` Avinesh Kumar [this message]
2025-06-30  8:45     ` Cyril Hrubis
2025-06-27 10:36 ` [LTP] [PATCH 1/2] lib: tst_test: Make IPC magic spells 'LTPM' Li Wang via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2803405.mvXUDI8C0e@thinkpad \
    --to=akumar@suse.de \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.