From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net: rename Ethernet header fields
Date: Wed, 06 Oct 2021 18:30:43 +0200 [thread overview]
Message-ID: <2804183.gA0sqFl6Ob@thomas> (raw)
In-Reply-To: <20211001163306.76538-2-dmitry.kozliuk@gmail.com>
01/10/2021 18:33, Dmitry Kozlyuk:
> Definition of `rte_ether_addr` structure used a workaround allowing DPDK
> and Windows SDK headers to be used in the same file, because Windows SDK
> defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr`
> to `dst_addr` to avoid the conflict and remove the workaround.
There is a compilation issue for Power:
app/test-pmd/macswap.h:32:33: error:
‘struct rte_ether_hdr’ has no member named ‘d_addr’
I think there are more misses:
% git grep -lw d_addr examples
examples/bond/main.c
examples/l3fwd-power/main.c
examples/l3fwd/l3fwd_em.h
examples/l3fwd/l3fwd_fib.c
examples/l3fwd/l3fwd_lpm.c
examples/l3fwd/l3fwd_lpm.h
examples/performance-thread/l3fwd-thread/main.c
next prev parent reply other threads:[~2021-10-06 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 21:40 [dpdk-dev] [PATCH 0/5] lib: Windows compatibility renaming Dmitry Kozlyuk
2021-09-15 21:40 ` [dpdk-dev] [PATCH 1/5] compressdev: rename fields for Windows compatibility Dmitry Kozlyuk
2021-09-23 17:06 ` Thomas Monjalon
2021-09-15 21:40 ` [dpdk-dev] [PATCH 2/5] cryptodev: " Dmitry Kozlyuk
2021-09-15 21:40 ` [dpdk-dev] [PATCH 3/5] table: rename local variable " Dmitry Kozlyuk
2021-09-15 21:40 ` [dpdk-dev] [PATCH 4/5] ring: rename local variables " Dmitry Kozlyuk
2021-09-15 22:31 ` Honnappa Nagarahalli
2021-09-15 21:40 ` [dpdk-dev] [PATCH 5/5] net: rename Ethernet header fields Dmitry Kozlyuk
2021-10-01 16:33 ` [dpdk-dev] [PATCH v2 0/2] net: Windows compatibility renaming Dmitry Kozlyuk
2021-10-01 16:33 ` [dpdk-dev] [PATCH v2 1/2] net: rename Ethernet header fields Dmitry Kozlyuk
2021-10-06 16:30 ` Thomas Monjalon [this message]
2021-10-01 16:33 ` [dpdk-dev] [PATCH v2 2/2] doc: remove unneeded deprecations Dmitry Kozlyuk
2021-10-07 22:07 ` [dpdk-dev] [PATCH v3 0/2] net: Windows compatibility renaming Dmitry Kozlyuk
2021-10-07 22:07 ` [dpdk-dev] [PATCH v3 1/2] net: rename Ethernet header fields Dmitry Kozlyuk
2021-10-08 12:54 ` Thomas Monjalon
2021-10-07 22:07 ` [dpdk-dev] [PATCH v3 2/2] doc: remove unneeded deprecations Dmitry Kozlyuk
2021-10-08 12:59 ` [dpdk-dev] [PATCH v3 0/2] net: Windows compatibility renaming Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2804183.gA0sqFl6Ob@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.