From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 22 Feb 2016 23:44:09 +0100 Subject: [PATCH 0/8] drm: msm: module rework In-Reply-To: References: <1456175331-714117-1-git-send-email-arnd@arndb.de> Message-ID: <2809632.WiXCV6JuAB@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 22 February 2016 17:36:36 Rob Clark wrote: > On Mon, Feb 22, 2016 at 4:08 PM, Arnd Bergmann wrote: > > I saw some regressions on today's Linux-next kernel after > > the Makefiles got reworked and tried to come up with a quick > > fix. This ended up taking much longer, but the new version should > > be cleaner and I no longer get any build errors in this > > driver. > > fyi, for the time being, I've already kicked out the kconfig/makefile > splitup patches.. > > I'll go ahead and pull in the hdmi symbol rename patch, since that is > a sane thing to do. Ok, thanks > I'm less sure about splitting things up into separate .ko's. I think it's generally a good idea to split it up like that, though it could be taken a little further. Having one .ko file per platform_driver seems to be a very sensible split here, the main advantage being that you enforce a strict layering between the subdrivers. > And I think having the .ko name not match the drm > driver name (ie. what is passed in to drmOpen() in userspace) would > cause issues since libdrm could try to modprobe $drivername.ko. (I > *think* that only matters in the non-udev case? Which is at least not > a common case, but breaking userspace is breaking userspace...) Ah, I see. Yes, that is unfortunate, but patch 2 then definitely has to be dropped even if you decide to take the others. With udev, the autoloading purely depends on the MODULE_DEVICE_TABLE in the top module, which should work fine, and without patch 2, all the other drivers get loaded automatically when the main driver gets probed. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0/8] drm: msm: module rework Date: Mon, 22 Feb 2016 23:44:09 +0100 Message-ID: <2809632.WiXCV6JuAB@wuerfel> References: <1456175331-714117-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7A596E2E3 for ; Mon, 22 Feb 2016 22:44:17 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-arm-kernel@lists.infradead.org Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gTW9uZGF5IDIyIEZlYnJ1YXJ5IDIwMTYgMTc6MzY6MzYgUm9iIENsYXJrIHdyb3RlOgo+IE9u IE1vbiwgRmViIDIyLCAyMDE2IGF0IDQ6MDggUE0sIEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIu ZGU+IHdyb3RlOgo+ID4gSSBzYXcgc29tZSByZWdyZXNzaW9ucyBvbiB0b2RheSdzIExpbnV4LW5l eHQga2VybmVsIGFmdGVyCj4gPiB0aGUgTWFrZWZpbGVzIGdvdCByZXdvcmtlZCBhbmQgdHJpZWQg dG8gY29tZSB1cCB3aXRoIGEgcXVpY2sKPiA+IGZpeC4gVGhpcyBlbmRlZCB1cCB0YWtpbmcgbXVj aCBsb25nZXIsIGJ1dCB0aGUgbmV3IHZlcnNpb24gc2hvdWxkCj4gPiBiZSBjbGVhbmVyIGFuZCBJ IG5vIGxvbmdlciBnZXQgYW55IGJ1aWxkIGVycm9ycyBpbiB0aGlzCj4gPiBkcml2ZXIuCj4gCj4g ZnlpLCBmb3IgdGhlIHRpbWUgYmVpbmcsIEkndmUgYWxyZWFkeSBraWNrZWQgb3V0IHRoZSBrY29u ZmlnL21ha2VmaWxlCj4gc3BsaXR1cCBwYXRjaGVzLi4KPiAKPiBJJ2xsIGdvIGFoZWFkIGFuZCBw dWxsIGluIHRoZSBoZG1pIHN5bWJvbCByZW5hbWUgcGF0Y2gsIHNpbmNlIHRoYXQgaXMKPiBhIHNh bmUgdGhpbmcgdG8gZG8uCgpPaywgdGhhbmtzCgo+ICBJJ20gbGVzcyBzdXJlIGFib3V0IHNwbGl0 dGluZyB0aGluZ3MgdXAgaW50byBzZXBhcmF0ZSAua28ncy4KCkkgdGhpbmsgaXQncyBnZW5lcmFs bHkgYSBnb29kIGlkZWEgdG8gc3BsaXQgaXQgdXAgbGlrZSB0aGF0LCB0aG91Z2gKaXQgY291bGQg YmUgdGFrZW4gYSBsaXR0bGUgZnVydGhlci4gSGF2aW5nIG9uZSAua28gZmlsZSBwZXIKcGxhdGZv cm1fZHJpdmVyIHNlZW1zIHRvIGJlIGEgdmVyeSBzZW5zaWJsZSBzcGxpdCBoZXJlLCB0aGUKbWFp biBhZHZhbnRhZ2UgYmVpbmcgdGhhdCB5b3UgZW5mb3JjZSBhIHN0cmljdCBsYXllcmluZyBiZXR3 ZWVuCnRoZSBzdWJkcml2ZXJzLgoKPiAgQW5kIEkgdGhpbmsgaGF2aW5nIHRoZSAua28gbmFtZSBu b3QgbWF0Y2ggdGhlIGRybQo+IGRyaXZlciBuYW1lIChpZS4gd2hhdCBpcyBwYXNzZWQgaW4gdG8g ZHJtT3BlbigpIGluIHVzZXJzcGFjZSkgd291bGQKPiBjYXVzZSBpc3N1ZXMgc2luY2UgbGliZHJt IGNvdWxkIHRyeSB0byBtb2Rwcm9iZSAkZHJpdmVybmFtZS5rby4gIChJCj4gKnRoaW5rKiB0aGF0 IG9ubHkgbWF0dGVycyBpbiB0aGUgbm9uLXVkZXYgY2FzZT8gIFdoaWNoIGlzIGF0IGxlYXN0IG5v dAo+IGEgY29tbW9uIGNhc2UsIGJ1dCBicmVha2luZyB1c2Vyc3BhY2UgaXMgYnJlYWtpbmcgdXNl cnNwYWNlLi4uKQoKQWgsIEkgc2VlLiBZZXMsIHRoYXQgaXMgdW5mb3J0dW5hdGUsIGJ1dCBwYXRj aCAyIHRoZW4gZGVmaW5pdGVseSBoYXMKdG8gYmUgZHJvcHBlZCBldmVuIGlmIHlvdSBkZWNpZGUg dG8gdGFrZSB0aGUgb3RoZXJzLgoKV2l0aCB1ZGV2LCB0aGUgYXV0b2xvYWRpbmcgcHVyZWx5IGRl cGVuZHMgb24gdGhlIE1PRFVMRV9ERVZJQ0VfVEFCTEUKaW4gdGhlIHRvcCBtb2R1bGUsIHdoaWNo IHNob3VsZCB3b3JrIGZpbmUsIGFuZCB3aXRob3V0IHBhdGNoIDIsIGFsbAp0aGUgb3RoZXIgZHJp dmVycyBnZXQgbG9hZGVkIGF1dG9tYXRpY2FsbHkgd2hlbiB0aGUgbWFpbiBkcml2ZXIKZ2V0cyBw cm9iZWQuCgoJQXJuZApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK