From: Thomas Monjalon <thomas@monjalon.net>
To: Kai Ji <kai.ji@intel.com>,
Didier Pallard <didier.pallard@6wind.com>,
gakhil@marvell.com
Cc: dev@dpdk.org, stable@dpdk.org,
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Michal Kobylinski <michalx.kobylinski@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Subject: Re: [PATCH] crypto/openssl: do not build useless workaround
Date: Sun, 25 Jun 2023 21:22:21 +0200 [thread overview]
Message-ID: <2809888.Y6S9NjorxK@thomas> (raw)
In-Reply-To: <20230418145619.2648068-1-didier.pallard@6wind.com>
18/04/2023 16:56, Didier Pallard:
> This workaround was needed before version 1.0.1f. Do not build it for
> versions >= 1.1.
>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Cc: stable@dpdk.org
[...]
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
> /* Workaround open ssl bug in version less then 1.0.1f */
> if (EVP_EncryptUpdate(ctx, empty, &unused, empty, 0) <= 0)
> goto process_auth_encryption_gcm_err;
> +#endif
What happens if we build with OpenSSL 1.1 and run with OpenSSL 1.0?
Can we have a runtime check?
Or is it better doing the workaround always as before?
next prev parent reply other threads:[~2023-06-25 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 14:56 [PATCH] crypto/openssl: do not build useless workaround Didier Pallard
2023-06-20 9:29 ` Ji, Kai
2023-06-20 11:00 ` Akhil Goyal
2023-06-25 19:22 ` Thomas Monjalon [this message]
2023-06-26 9:13 ` Didier Pallard
2023-06-26 10:04 ` Thomas Monjalon
2023-06-26 10:39 ` Didier Pallard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2809888.Y6S9NjorxK@thomas \
--to=thomas@monjalon.net \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
--cc=michalx.kobylinski@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
--cc=stable@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.