From: David Howells <dhowells@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: dhowells@redhat.com, Amir Goldstein <amir73il@gmail.com>,
Dave Chinner <david@fromorbit.com>, NeilBrown <neilb@suse.de>,
Kent Overstreet <kent.overstreet@linux.dev>,
Donald Buczek <buczek@molgen.mpg.de>,
linux-bcachefs@vger.kernel.org,
Stefan Krueger <stefan.krueger@aei.mpg.de>,
linux-fsdevel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org
Subject: Re: file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?)
Date: Tue, 12 Dec 2023 09:10:47 +0000 [thread overview]
Message-ID: <2810685.1702372247@warthog.procyon.org.uk> (raw)
In-Reply-To: <20231212-impfung-linden-6f973f2ade19@brauner>
Christian Brauner <brauner@kernel.org> wrote:
> > > > I suggest:
> > > >
> > > > STATX_ATTR_INUM_NOT_UNIQUE - it is possible that two files have the
> > > > same inode number
>
> This is just ugly with questionable value. A constant reminder of how
> broken this is. Exposing the subvolume id also makes this somewhat redundant.
There is a upcoming potential problem where even the 64-bit field I placed in
statx() may be insufficient. The Auristor AFS server, for example, has a
96-bit vnode ID, but I can't properly represent this in stx_ino. Currently, I
just truncate the value to fit and hope that the discarded part will be all
zero, but that's not really a good thing to do - especially when stx_ino is
used programmatically to check for hardlinks.
Would it be better to add an 'stx_ino_2' field and corresponding flag?
David
next prev parent reply other threads:[~2023-12-12 9:10 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 7:49 How to cope with subvolumes and snapshots on muti-user systems? Donald Buczek
2023-11-29 21:43 ` Kent Overstreet
2023-11-30 7:35 ` Donald Buczek
2023-11-30 7:39 ` Kent Overstreet
2023-11-30 20:37 ` NeilBrown
2023-12-04 10:47 ` Donald Buczek
2023-12-04 22:45 ` NeilBrown
2023-12-05 21:35 ` Donald Buczek
2023-12-05 22:01 ` NeilBrown
2023-12-07 11:53 ` Donald Buczek
2023-12-08 1:16 ` NeilBrown
2023-12-08 1:37 ` Kent Overstreet
2023-12-08 2:13 ` NeilBrown
2023-12-08 2:49 ` Kent Overstreet
2023-12-08 11:34 ` Donald Buczek
2023-12-08 20:02 ` Kent Overstreet
2023-12-11 22:43 ` NeilBrown
2023-12-11 23:32 ` file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?) Kent Overstreet
2023-12-11 23:40 ` David Howells
2023-12-12 20:59 ` Kent Overstreet
2023-12-12 22:57 ` NeilBrown
2023-12-12 23:43 ` Kent Overstreet
2023-12-13 0:02 ` NeilBrown
2023-12-13 0:14 ` Kent Overstreet
2023-12-13 22:45 ` Andreas Dilger
2023-12-13 23:24 ` Kent Overstreet
2023-12-11 23:53 ` NeilBrown
2023-12-12 0:05 ` Kent Overstreet
2023-12-12 0:59 ` NeilBrown
2023-12-12 1:10 ` Kent Overstreet
2023-12-12 2:13 ` NeilBrown
2023-12-12 2:24 ` Kent Overstreet
2023-12-12 9:08 ` Christian Brauner
2023-12-12 5:53 ` Dave Chinner
2023-12-12 6:32 ` Amir Goldstein
2023-12-12 8:56 ` Christian Brauner
2023-12-12 9:10 ` David Howells [this message]
2023-12-12 9:23 ` Christian Brauner
2023-12-12 9:28 ` Miklos Szeredi
2023-12-12 9:35 ` Christian Brauner
2023-12-12 9:42 ` Miklos Szeredi
2023-12-12 13:47 ` Christian Brauner
2023-12-12 14:06 ` Miklos Szeredi
2023-12-12 15:24 ` Christian Brauner
2023-12-12 15:28 ` Kent Overstreet
2023-12-12 9:46 ` David Howells
2023-12-12 15:16 ` Kent Overstreet
2023-12-12 15:29 ` Christian Brauner
2023-12-12 15:35 ` Kent Overstreet
2023-12-12 15:38 ` Miklos Szeredi
2023-12-12 15:43 ` Kent Overstreet
2023-12-12 15:57 ` Miklos Szeredi
2023-12-12 16:08 ` Kent Overstreet
2023-12-12 16:30 ` Miklos Szeredi
2023-12-12 16:41 ` Kent Overstreet
2023-12-12 21:53 ` NeilBrown
2023-12-13 9:41 ` Christian Brauner
2023-12-12 21:46 ` NeilBrown
2023-12-13 9:47 ` Christian Brauner
2023-12-13 10:04 ` Christian Brauner
2023-12-14 22:47 ` NeilBrown
2023-12-15 0:36 ` Kent Overstreet
2023-12-12 7:03 ` David Howells
2023-12-12 9:10 ` file handle in statx Donald Buczek
2023-12-12 15:20 ` Theodore Ts'o
2023-12-12 17:15 ` Frank Filz
2023-12-12 17:44 ` Kent Overstreet
2023-12-12 18:17 ` Amir Goldstein
2023-12-12 19:18 ` Frank Filz
2023-12-12 20:59 ` Dave Chinner
2023-12-12 21:57 ` NeilBrown
2023-12-12 22:23 ` Dave Chinner
2023-12-12 22:36 ` NeilBrown
2023-12-12 22:39 ` Kent Overstreet
2023-12-12 23:44 ` Dave Chinner
2023-12-13 0:00 ` Kent Overstreet
2023-12-13 7:37 ` Donald Buczek
2023-12-13 12:28 ` Kent Overstreet
2023-12-13 13:48 ` Donald Buczek
2023-12-19 7:41 ` Donald Buczek
2023-12-12 15:21 ` file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?) Kent Overstreet
2023-12-12 20:48 ` Dave Chinner
2023-12-12 21:23 ` Kent Overstreet
2023-12-12 22:10 ` Dave Chinner
2023-12-12 22:31 ` NeilBrown
2023-12-12 23:06 ` Dave Chinner
2023-12-12 23:42 ` Kent Overstreet
2023-12-13 0:03 ` NeilBrown
2023-12-12 22:00 ` NeilBrown
2023-12-12 0:25 ` David Howells
2023-12-13 12:43 ` How to cope with subvolumes and snapshots on muti-user systems? Donald Buczek
2023-11-30 20:36 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2810685.1702372247@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=buczek@molgen.mpg.de \
--cc=david@fromorbit.com \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stefan.krueger@aei.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.