From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 0/4] bnx2x: new poll mode driver
Date: Thu, 09 Jul 2015 23:27:47 +0200 [thread overview]
Message-ID: <2812093.yvipHqyS69@xps13> (raw)
In-Reply-To: <20150709141545.4f4aa344@urahara>
2015-07-09 14:15, Stephen Hemminger:
> On Thu, 09 Jul 2015 22:41:23 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > REJECTED
> >
> > 2015-07-09 11:15, Stephen Hemminger:
> > > Changes in this version:
> > > - rebase for PCI uio changes
> > > - fix version map for 2.1
> > > - add BCM57840 support
> >
> > You ignore the comments which are done.
> > Examples for this series:
> > http://dpdk.org/ml/archives/dev/2015-June/019556.html
> > http://dpdk.org/ml/archives/dev/2015-July/020714.html
> > You rarely reply to comments and you seem laughing when versioning the patches:
>
> Sorry, it was so long between versions I lost track.
>
>
> > v4 on 05-08: http://dpdk.org/ml/archives/dev/2015-May/017438.html
> > v5 on 06-17: http://dpdk.org/ml/archives/dev/2015-June/019490.html
> > v3 on 07-08: http://dpdk.org/ml/archives/dev/2015-July/021046.html
> > v4 on 08-08: http://dpdk.org/ml/archives/dev/2015-July/021277.html
> >
> > This series still has some obvious errors.
> > I may help to review them if you show that you care about previous comments
> > like doxygen errors, correct linker file syntax or even git send-email
> > guidelines.
>
> I will go back and fix doxygen, what is the linker issue?
The example I've given shows a keyword "global:" that you missed.
> The send-email guidelines issues are unclear??
It's explained in http://dpdk.org/dev#send.
Good usage of --subject-prefix, --annotate and --in-reply-to are expected.
> QLogic is helping out, there maybe a couple of other changes as well.
prev parent reply other threads:[~2015-07-09 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 18:15 [PATCH v4 0/4] bnx2x: new poll mode driver Stephen Hemminger
2015-07-09 18:15 ` [PATCH 1/4] eal: provide functions to access PCI config Stephen Hemminger
2015-07-09 18:15 ` [PATCH 2/4] bnx2x: driver core Stephen Hemminger
2015-07-09 18:15 ` [PATCH 3/4] bnx2x: driver support routines Stephen Hemminger
2015-07-09 18:15 ` [PATCH 4/4] bnx2x: enable PMD build Stephen Hemminger
2015-07-09 20:41 ` [PATCH v4 0/4] bnx2x: new poll mode driver Thomas Monjalon
2015-07-09 21:15 ` Stephen Hemminger
2015-07-09 21:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2812093.yvipHqyS69@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.