From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: linux-pm@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Marco Felsch <m.felsch@pengutronix.de>
Subject: Re: [PATCH 1/3] pmdomain: imx93-blk-ctrl: cleanup error path
Date: Tue, 02 Dec 2025 08:48:54 +0100 [thread overview]
Message-ID: <2812632.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <20251201-v6-18-topic-imx93-blkctrl-v1-1-b57a72e60105@pengutronix.de>
Am Montag, 1. Dezember 2025, 18:12:05 CET schrieb Marco Felsch:
> Call dev_err_probe() directly during return to make the code more
> compact.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/pmdomain/imx/imx93-blk-ctrl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pmdomain/imx/imx93-blk-ctrl.c b/drivers/pmdomain/imx/imx93-blk-ctrl.c
> index e094fe5a42bf646c712f3eca4e66a313fa5a914c..2aa163aef8de4ee901b9cde76ce2aad246c8c08a 100644
> --- a/drivers/pmdomain/imx/imx93-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx93-blk-ctrl.c
> @@ -240,10 +240,8 @@ static int imx93_blk_ctrl_probe(struct platform_device *pdev)
> bc->num_clks = bc_data->num_clks;
>
> ret = devm_clk_bulk_get(dev, bc->num_clks, bc->clks);
> - if (ret) {
> - dev_err_probe(dev, ret, "failed to get bus clock\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "failed to get bus clock\n");
>
> for (i = 0; i < bc_data->num_domains; i++) {
> const struct imx93_blk_ctrl_domain_data *data = &bc_data->domains[i];
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2025-12-02 7:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 17:12 [PATCH 0/3] i.MX91/93 BLK-CTRL improvements Marco Felsch
2025-12-01 17:12 ` [PATCH 1/3] pmdomain: imx93-blk-ctrl: cleanup error path Marco Felsch
2025-12-01 22:37 ` Frank Li
2025-12-02 7:48 ` Alexander Stein [this message]
2025-12-01 17:12 ` [PATCH 2/3] pmdomain: imx93-blk-ctrl: convert to devm_* only Marco Felsch
2025-12-01 22:41 ` Frank Li
2025-12-02 7:57 ` Marco Felsch
2025-12-01 17:12 ` [PATCH 3/3] pmdomain: imx93-blk-ctrl: add support for optional subnodes Marco Felsch
2025-12-01 22:42 ` Frank Li
2025-12-02 7:49 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2812632.mvXUDI8C0e@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.