Re: [RFC] eal: rename state values in rte_lcore_state

[Thomas Monjalon <thomas@monjalon.net>]

26/03/2019 20:25, Stephen Hemminger:
> C language does not really treat enum's as first class symbols.
> The values in an enum live in a global namespace.  That means if
> DPDK defines "RUNNING" it can't be used by another enum in an
> application using DPDK.
> 
> To solve this add a prefix "LCORE_" to the enum values, and
> make them grammatically consistent.
> 
[...]
>  enum rte_lcore_state_t {
> -	WAIT,       /**< waiting a new command */
> -	RUNNING,    /**< executing command */
> -	FINISHED,   /**< command executed */
> +	LCORE_WAITING,    /**< waiting a new command */
> +	LCORE_RUNNING,    /**< executing command */
> +	LCORE_FINISHED,   /**< command executed */
>  };

We have some old namespace issues in DPDK.
While improving the public namespace, please fix it definitely
by prefixing with "RTE_".

PS: I would prefer DPDK_ prefix but that's not what is used currently.