From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com,
yuanhan.liu@linux.intel.com, stephen@networkplumber.org
Subject: Re: [PATCH 3/3] doc: remove ABI changes in igb_uio
Date: Mon, 30 Jan 2017 18:52:39 +0100 [thread overview]
Message-ID: <2816494.kdcLa2jDNL@xps13> (raw)
In-Reply-To: <66ee7e72-95a3-1e31-278c-b6823168de6c@intel.com>
2017-01-24 13:35, Ferruh Yigit:
> On 1/24/2017 7:34 AM, Jianfeng Tan wrote:
> > We announced ABI changes to remove iomem and ioport mapping in
> > igb_uio. But it has potential backward compatibility issue: cannot
> > run old version DPDK on modified igb_uio.
> >
> > The purpose of this changes was to fix a bug: when DPDK app crashes,
> > those devices by igb_uio are not stopped either DPDK PMD driver or
> > igb_uio driver. We need to figure out new way to fix this bug.
>
> Hi Jianfeng,
>
> I believe it would be good to fix this potential defect.
>
> Is "remove iomem and ioport" a must for that fix? If so, I suggest
> re-think about it.
>
> If I see correctly, dpdk1.8 and older uses igb_uio iomem files. So
> backward compatibility is the possible issue for dpdk1.8 and older.
> Since v1.8 two years old, I would prefer fixing defect instead of
> keeping that backward compatibility.
>
> Jianfeng, Thomas,
>
> What do you think postponing this deprecation notice to next release,
> instead of removing it, and discuss more?
>
>
> And overall, if "remove iomem and ioport" is not a must for this fix, no
> problem to remove deprecation notice.
I have no strong opinion here.
Jianfeng, do you agree with Ferruh?
next prev parent reply other threads:[~2017-01-30 17:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 7:34 [PATCH 0/3] doc upates Jianfeng Tan
2017-01-24 7:34 ` [PATCH 1/3] doc: add guide to use virtio_user for container networking Jianfeng Tan
2017-01-24 7:34 ` [PATCH 2/3] doc: add guide to use virtio_user as exceptional path Jianfeng Tan
2017-01-24 7:34 ` [PATCH 3/3] doc: remove ABI changes in igb_uio Jianfeng Tan
2017-01-24 13:35 ` Ferruh Yigit
2017-01-30 17:52 ` Thomas Monjalon [this message]
2017-02-01 7:24 ` Tan, Jianfeng
2017-02-09 14:45 ` [PATCH 0/3] doc upates Thomas Monjalon
2017-02-09 16:06 ` [PATCH v2 " Jianfeng Tan
2017-02-09 16:06 ` [PATCH v2 1/3] doc: add guide to use virtio_user for container networking Jianfeng Tan
2017-02-09 16:06 ` [PATCH v2 2/3] doc: add guide to use virtio_user as exceptional path Jianfeng Tan
2017-02-09 16:06 ` [PATCH v2 3/3] doc: postpone ABI changes in igb_uio Jianfeng Tan
2017-02-09 17:40 ` Ferruh Yigit
2017-02-10 10:44 ` Thomas Monjalon
2017-02-10 11:20 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2816494.kdcLa2jDNL@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.