From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Dai <wei.dai@intel.com>
Cc: stable@dpdk.org, thomas.monjalon@6wind.com,
harish.patil@cavium.com, rasesh.mody@cavium.com,
stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com,
wenzhuo.lu@intel.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, jingjing.wu@intel.com,
jing.d.chen@intel.com, adrien.mazarguil@6wind.com,
nelio.laranjeiro@6wind.com, bruce.richardson@intel.com,
yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,
dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr
Date: Thu, 20 Apr 2017 23:43:50 +0200 [thread overview]
Message-ID: <2816605.jEqPTYToiQ@xps> (raw)
In-Reply-To: <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com>
13/04/2017 10:21, Wei Dai:
> some customers find adding mac addr to VF sometimes can fail,
> but it is still stored in dev->data->mac_addrs[ ]. So this
> can lead to some errors that assumes the non-zero entry in
> dev->data->mac_addrs[ ] is valid.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
> drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++++--
> drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------
> drivers/net/e1000/base/e1000_api.c | 2 +-
> drivers/net/e1000/em_ethdev.c | 6 +++---
> drivers/net/e1000/igb_ethdev.c | 5 +++--
> drivers/net/enic/enic.h | 2 +-
> drivers/net/enic/enic_ethdev.c | 4 ++--
> drivers/net/enic/enic_main.c | 6 +++---
> drivers/net/fm10k/fm10k_ethdev.c | 3 ++-
> drivers/net/i40e/i40e_ethdev.c | 11 ++++++-----
> drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++----
> drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++++++++---------
> drivers/net/mlx4/mlx4.c | 18 +++++++++++-------
> drivers/net/mlx5/mlx5.h | 4 ++--
> drivers/net/mlx5/mlx5_mac.c | 16 ++++++++++------
> drivers/net/qede/qede_ethdev.c | 6 ++++--
> drivers/net/ring/rte_eth_ring.c | 3 ++-
> drivers/net/virtio/virtio_ethdev.c | 13 +++++++------
> lib/librte_ether/rte_ethdev.c | 15 +++++++++------
> lib/librte_ether/rte_ethdev.h | 2 +-
> 20 files changed, 100 insertions(+), 70 deletions(-)
Please, could you rebase and add changes to newly introduced drivers?
Thanks
next prev parent reply other threads:[~2017-04-20 21:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 9:02 [PATCH v3 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-04-12 9:02 ` [PATCH v3 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-12 9:30 ` Nélio Laranjeiro
2017-04-12 9:02 ` [PATCH v3 2/3] doc: change type of return value of adding " Wei Dai
2017-04-12 9:02 ` [PATCH v3 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-13 8:21 ` [PATCH v4 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-04-13 8:21 ` [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-13 8:44 ` Nélio Laranjeiro
2017-04-13 9:22 ` Dai, Wei
2017-04-20 5:31 ` Yuanhan Liu
2017-04-20 21:43 ` Thomas Monjalon [this message]
2017-04-21 6:43 ` Lu, Wenzhuo
2017-04-29 6:09 ` Dai, Wei
2017-05-02 1:21 ` Lu, Wenzhuo
2017-05-02 1:51 ` Dai, Wei
2017-04-13 8:21 ` [PATCH v4 2/3] doc: change type of return value of adding " Wei Dai
2017-04-14 16:03 ` Mcnamara, John
2017-04-13 8:21 ` [PATCH v4 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-13 13:54 ` [PATCH v4 0/3] MAC address fail to be added shouldn't be stored Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2816605.jEqPTYToiQ@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=stable@dpdk.org \
--cc=stephen.hurd@broadcom.com \
--cc=thomas.monjalon@6wind.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.