From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Daniel J Blueman <daniel@quora.org>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] HDA: Fix digital microphone on CS420x
Date: Mon, 05 Nov 2012 09:59:21 +0100 [thread overview]
Message-ID: <28172648.UT99xke6PI@ws-stein> (raw)
In-Reply-To: <CAMVG2sv2dD=WXAiJnpEO7e-pnJ5gOnCn0JK5P+B_SWc4Wqg36w@mail.gmail.com>
Hello,
On Monday 05 November 2012 07:22:24, Daniel J Blueman wrote:
> On 4 November 2012 16:16, Takashi Iwai <tiwai@suse.de> wrote:
> > Thanks, this looks more comprehensive. DIG1 and DIG2 seem to have
> > been set wrongly in the original code, based on the Cirrus's example
> > code. Is the right-only recording problem fixed by this patch?
> >
>
> It is fixed. In the mbp101 init verbs, setting the vendor widget ADC
> configuration bit 12 to copy the ADC2 right channel to the left (0x1004 to
> nid 0x11 coef 2) is superfluous here, so presumably for the analogue mic
> in. I'll get time later to check all this.
>
> The second coefficient index initialisation (0x000f to nid 0x11 coef 4) is
> now redundant, as we enable the mic bits later correctly now. I'll send an
> updated patch which drops this.
>
> Alexander, could you check this doesn't break your machine?
I replaced my 2nd patch "hda: Cirrus: Fix wrong ADC config" with Daniel's
patch "HDA: Fix digital microphone on CS420x" and I still get stereo in both
ADC channels I'm using. So, no breakage, but I can't comment on the digital
mic patch, because I'm not using it.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
August-Bebel-Str. 29
D-07973 Greiz
Tel: +49-3661-6279-0, Fax: +49-3661-6279-99
eMail: Alexander.Stein@systec-electronic.com
Internet: http://www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Jena, HRB 205563
next prev parent reply other threads:[~2012-11-05 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 5:19 [PATCH 1/2] HDA: Fix digital microphone on CS420x Daniel J Blueman
2012-11-04 5:19 ` Daniel J Blueman
2012-11-04 5:19 ` [PATCH 2/2] HDA: Mark CS260x immutable structures const Daniel J Blueman
2012-11-04 8:16 ` [PATCH 1/2] HDA: Fix digital microphone on CS420x Takashi Iwai
2012-11-04 23:22 ` Daniel J Blueman
2012-11-05 8:59 ` Alexander Stein [this message]
2012-11-05 11:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28172648.UT99xke6PI@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@quora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.