From: Francesco Romani <fromani@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kwolf@redhat.com, lcapitulino@redhat.com,
mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold
Date: Tue, 2 Dec 2014 10:11:29 -0500 (EST) [thread overview]
Message-ID: <281933196.5591923.1417533089271.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20141202150117.GA12390@stefanha-thinkpad.redhat.com>
----- Original Message -----
> From: "Stefan Hajnoczi" <stefanha@redhat.com>
> To: "Francesco Romani" <fromani@redhat.com>
> Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
> Sent: Tuesday, December 2, 2014 4:01:17 PM
> Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold
>
> On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote:
> > @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState
> > *bs)
> > info->iops_size = cfg.op_size;
> > }
> >
> > + info->write_threshold = bdrv_usage_threshold_get(bs);
>
> Overall looks good but I notice that "write_threshold" and
> "usage_threshold" are both used. Please use just one consistently (I
> think "write_threshold" is clearer).
Agreed. Will use "write_threshold" everywhere, file names included.
Bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani
prev parent reply other threads:[~2014-12-02 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 12:31 [Qemu-devel] [PATCH v3] add write threshold reporting for block devices Francesco Romani
2014-11-28 12:31 ` [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold Francesco Romani
2014-12-01 21:07 ` Eric Blake
2014-12-02 7:47 ` Francesco Romani
2014-12-02 8:07 ` Francesco Romani
2014-12-02 15:01 ` Stefan Hajnoczi
2014-12-02 15:11 ` Francesco Romani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=281933196.5591923.1417533089271.JavaMail.zimbra@redhat.com \
--to=fromani@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.