From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal/x86: Fix build with clang for old AVX
Date: Thu, 04 Feb 2016 22:32:23 +0100 [thread overview]
Message-ID: <2821262.qCsjkLddf6@xps13> (raw)
In-Reply-To: <1454551954-45356-1-git-send-email-zhihong.wang@intel.com>
2016-02-03 21:12, Zhihong Wang:
> When configuring RTE_MACHINE to "default", rte_memcpy implementation
> is the default one (old AVX).
> In this code, clang raises a warning thanks to -Wsometimes-uninitialized:
>
> rte_memcpy.h:838:6: error:
> variable 'srcofs' is used uninitialized whenever 'if' condition is false
> if (dstofss > 0) {
> ^~~~~~~~~~~
> rte_memcpy.h:849:6: note: uninitialized use occurs here
> if (srcofs == 0) {
> ^~~~~~
>
> It is fixed by moving srcofs initialization out of the condition.
> Also dstofss calculation is corrected.
>
> Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512")
>
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-02-04 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 2:12 [PATCH] eal/x86: Fix build with clang for old AVX Zhihong Wang
2016-02-04 21:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2821262.qCsjkLddf6@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.