From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:45174 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754891Ab2IYLlh (ORCPT ); Tue, 25 Sep 2012 07:41:37 -0400 From: Laurent Pinchart To: Sylwester Nawrocki Cc: linux-media@vger.kernel.org, a.hajda@samsung.com, sakari.ailus@iki.fi, hverkuil@xs4all.nl, kyungmin.park@samsung.com, sw0312.kim@samsung.com Subject: Re: [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format Date: Tue, 25 Sep 2012 13:42:13 +0200 Message-ID: <2823843.qYtB3rcnKu@avalon> In-Reply-To: <1348498546-2652-2-git-send-email-s.nawrocki@samsung.com> References: <1348498546-2652-1-git-send-email-s.nawrocki@samsung.com> <1348498546-2652-2-git-send-email-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sylwester, On Monday 24 September 2012 16:55:42 Sylwester Nawrocki wrote: > This patch adds media bus pixel code for the interleaved JPEG/UYVY > image format used by S5C73MX Samsung cameras. This interleaved image > data is transferred on MIPI-CSI2 bus as User Defined Byte-based Data. > > It also defines an experimental vendor and device specific media bus > formats section and adds related DocBook documentation. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > Documentation/DocBook/media/v4l/compat.xml | 4 ++ > Documentation/DocBook/media/v4l/subdev-formats.xml | 45 +++++++++++++++++++ > include/linux/v4l2-mediabus.h | 5 +++ > 3 files changed, 54 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/compat.xml > b/Documentation/DocBook/media/v4l/compat.xml index 98e8d08..5d2480b 100644 > --- a/Documentation/DocBook/media/v4l/compat.xml > +++ b/Documentation/DocBook/media/v4l/compat.xml > @@ -2605,6 +2605,10 @@ ioctls. > > Support for frequency band enumeration: &VIDIOC-ENUM-FREQ-BANDS; > ioctl. > + > + Vendor and device specific media bus pixel formats. > + . > + > > > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml > b/Documentation/DocBook/media/v4l/subdev-formats.xml index 49c532e..d7aa870 > 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > @@ -2565,5 +2565,50 @@ > > > > + > +
> + Vendor and Device Specific Formats > + > + > + Experimental I don't think you need spaces across the title. > + This is an experimental > +interface and may change in the future. > + > + > + This section lists complex data formats that are either vendor > or > + device specific. These formats comprise raw and compressed image data > + and optional meta-data within a single frame. That's currently true, but we could have other strange vendor-specific formats that don't interleave raw and compressed frames. > + > + > + The following table lists the existing vendor and device > specific > + formats. > + > + id="v4l2-mbus-pixelcode-vendor-specific"> + Vendor and device > specific formats > + > + > + > + > + > + > + Identifier > + Code > + Comments > + > + > + > + > + V4L2_MBUS_FMT_S5C_UYVY_JPG_1X8 > + 0x8001 > + > + Interleaved raw UYVY and JPEG image format with embedded > + meta-data, produced by S3C73M3 camera sensors. > + > + > + > + > +
> +
> + > > > diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h > index 5ea7f75..b98c566 100644 > --- a/include/linux/v4l2-mediabus.h > +++ b/include/linux/v4l2-mediabus.h > @@ -92,6 +92,11 @@ enum v4l2_mbus_pixelcode { > > /* JPEG compressed formats - next is 0x4002 */ > V4L2_MBUS_FMT_JPEG_1X8 = 0x4001, > + > + /* Vendor specific formats - next is 0x8002 */ Anything wrong with 0x5000 as a base value ? :-) > + > + /* S5C73M3 interleaved UYVY and JPEG */ > + V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 = 0x8001, > }; > > /** -- Regards, Laurent Pinchart