diff for duplicates of <2828625.Bdym394lFc@avalon> diff --git a/a/1.txt b/N1/1.txt index b0144f9..fabc31b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -80,7 +80,7 @@ This is inside the #if CONFIG_FB_MODE_HELPERS block, is that intentional ? > + else > + fbmode->refresh = vm->pixelclock; -What about returning an error if htotal * vtotal = 0 ? The input is clearly +What about returning an error if htotal * vtotal == 0 ? The input is clearly invalid in that case. I would then set fbmode->refresh to 0, setting it to vm- >pixelclock doesn't really make sense. diff --git a/a/content_digest b/N1/content_digest index 6b3ffe3..87b4363 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01353661467-28545-5-git-send-email-s.trumtrar@pengutronix.de\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCHv14 4/7] fbmon: add videomode helpers\0" - "Date\0Fri, 23 Nov 2012 10:53:10 +0000\0" + "Date\0Fri, 23 Nov 2012 11:53:10 +0100\0" "To\0Steffen Trumtrar <s.trumtrar@pengutronix.de>\0" "Cc\0devicetree-discuss@lists.ozlabs.org" Rob Herring <robherring2@gmail.com> @@ -100,7 +100,7 @@ "> +\telse\n" "> +\t\tfbmode->refresh = vm->pixelclock;\n" "\n" - "What about returning an error if htotal * vtotal = 0 ? The input is clearly \n" + "What about returning an error if htotal * vtotal == 0 ? The input is clearly \n" "invalid in that case. I would then set fbmode->refresh to 0, setting it to vm-\n" ">pixelclock doesn't really make sense.\n" "\n" @@ -147,4 +147,4 @@ "\n" Laurent Pinchart -c015335508179662e08a86de369c69702c638c1ebcccdace9e90831f91d39fba +2f33b1974a8dbcb3fad15e96a5ee308436aca0a526655abf5f2eb9108b9e19c7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.