All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Charlie Johnston" <charlie.johnston@loftorbital.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] fetch2: Ensure GCP fetcher checks if file exists before download.
Date: Wed, 21 Aug 2024 10:41:21 -0700	[thread overview]
Message-ID: <28323.1724262081445932896@lists.openembedded.org> (raw)
In-Reply-To: <CAHUKmYaTcWnhQVcbD6GAnz5ymwUv3GwjfVx6d4kOyDCzrpCCQA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hello,

I actually ran into the slowness of gsutil stat recently and have been testing a patch locally that does something similar to what you describe. The difference is that I modified it to drop the runfetchcomd and raise a FetchError if self.gcp_client.bucket(ud.host).blob(path).exists() is false.
Is that approach acceptable, or is it better to bundle it into the download_to_filename logic as you describe?

Regards,
Charlie

[-- Attachment #2: Type: text/html, Size: 3318 bytes --]

  reply	other threads:[~2024-08-21 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 13:11 [PATCH] fetch2: Ensure GCP fetcher checks if file exists before download Charlie Johnston
2024-08-21 11:13 ` [bitbake-devel] " Etienne Cordonnier
     [not found] ` <17EDBA14A1399376.18027@lists.openembedded.org>
2024-08-21 11:19   ` Etienne Cordonnier
2024-08-21 17:41     ` Charlie Johnston [this message]
2024-08-22 10:37       ` Etienne Cordonnier
     [not found]       ` <17EE06B6AD411EA3.9439@lists.openembedded.org>
2024-08-22 11:30         ` Etienne Cordonnier
2024-08-22 18:30           ` Charlie Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28323.1724262081445932896@lists.openembedded.org \
    --to=charlie.johnston@loftorbital.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.