From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, matan@mellanox.com, ferruh.yigit@intel.com
Subject: Re: [PATCH] bus/vdev: reduce scope of device list lock
Date: Tue, 22 May 2018 11:20:10 +0200 [thread overview]
Message-ID: <2833093.uzJjkH71XI@xps> (raw)
In-Reply-To: <8f0eb83d-5090-c7c8-5c3d-c4eecb96e596@intel.com>
22/05/2018 11:05, Burakov, Anatoly:
> On 21-May-18 5:11 PM, Thomas Monjalon wrote:
> > The lock vdev_device_list_lock was taken before calling
> > "remove" function for the device.
> > So it prevents to remove sub-devices (as in failsafe) inside
> > its own "remove" function, because of a deadlock.
> >
> > The lock is now only protecting the device list inside
> > the bus driver.
> >
> > Fixes: 35f462839b69 ("bus/vdev: add lock on device list")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Without that lock, all of this would be racy - find_dev would iterate a
> tailq that might change under its feet, and tailq_remove may be called
> with a pointer that has already been removed.
>
> How about changing the lock to a recursive lock? Failsafe would be
> removing devices from within the same thread, correct?
Yes it could work.
I will give it a try.
next prev parent reply other threads:[~2018-05-22 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 16:11 [PATCH] bus/vdev: reduce scope of device list lock Thomas Monjalon
2018-05-21 16:45 ` [PATCH v2] bus/vdev: fix " Thomas Monjalon
2018-05-21 17:28 ` Matan Azrad
2018-05-22 9:11 ` Gaëtan Rivet
2018-05-22 9:05 ` [PATCH] bus/vdev: reduce " Burakov, Anatoly
2018-05-22 9:20 ` Thomas Monjalon [this message]
2018-05-22 11:37 ` [PATCH v3] bus/vdev: replace device list lock by a recursive one Thomas Monjalon
2018-05-22 12:08 ` Matan Azrad
2018-05-22 13:34 ` Burakov, Anatoly
2018-05-22 14:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2833093.uzJjkH71XI@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.