Re: [PATCH 1/2] build: add backward compatibility for nested drivers

[Thomas Monjalon <thomas@monjalon.net>]

22/09/2025 13:07, Kevin Traynor:
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> -# add cmdline disabled drivers and meson disabled drivers together
> -disable_drivers += ',' + get_option('disable_drivers')
> +# map legacy driver names
> +driver_map = {
> +    'net/e1000': 'net/intel/e1000',
> +    'net/fm10k': 'net/intel/fm10k',
> +    'net/i40e': 'net/intel/i40e',
> +    'net/iavf': 'net/intel/iavf',
> +    'net/ice': 'net/intel/ice',
> +    'net/idpf': 'net/intel/idpf',
> +    'net/ipn3ke': 'net/intel/ipn3ke',
> +    'net/ixgbe': 'net/intel/ixgbe',
> +    'net/cpfl': 'net/intel/cpfl',
> +}

Should we build this list inside a file drivers/net/intel/meson.build ?
I'm not sure my idea is better...

> +
> +# add cmdline drivers
> +foreach driver_type : [['disable', get_option('disable_drivers')],
> +                       ['enable', get_option('enable_drivers')]]
> +    driver_list_name = driver_type[0] + '_drivers'
> +    cmdline_drivers = ',' + driver_type[1]
> +
> +    foreach driver : cmdline_drivers.split(',')
> +        if driver_map.has_key(driver)

I feel we need comments for above parsing.

> +            driver_mapped = driver_map[driver]
> +            warning('Driver name "@0@" is deprecated, please use "@1@" instead.'

Not sure about this warning.
We can keep compatibility without saying it is deprecated.

> +                    .format(driver, driver_mapped))
> +            driver = driver_mapped
> +        endif
> +        if driver_list_name == 'disable_drivers'
> +            disable_drivers += ',' + driver
> +        else
> +            enable_drivers += ',' + driver
> +        endif
> +    endforeach
> +endforeach
> +
> +# add cmdline drivers and meson drivers together

This comment is not clear.

>  disable_drivers = run_command(list_dir_globs, disable_drivers, check: true).stdout().split()
> -
> -# add cmdline enabled drivers and meson enabled drivers together
> -enable_drivers = ',' + get_option('enable_drivers')