All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Andy Gospodarek <gospo@cumulusnetworks.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Veaceslav Falico <vfalico@gmail.com>,
	Nikolay Aleksandrov <nikolay@redhat.com>,
	David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH next 4/6] bonding: Allow userspace to set system_priority
Date: Mon, 09 Feb 2015 23:05:17 -0800	[thread overview]
Message-ID: <28432.1423551917@famine> (raw)
In-Reply-To: <CAF2d9jhkSD+EyHLzJSjS9rXdDCSfEQyFD5X9-D9KmGPFeu2RWA@mail.gmail.com>

Mahesh Bandewar <maheshb@google.com> wrote:
[...]
>Actually I was thinking of making ad_actor_sysprio instead of making
>ad_user_port_key (feels like having more underscores makes it
>unnecessary longer). That way all three look similar. So
>
>         ad_actor_sysprio
>         ad_actor_system
>         ad_user_portkey
>
>All carry the same theme of meaning. Otherwise we could do something like -
>
>         ad_actor_sys_prio
>         ad_actor_sys_mac
>         ad_user_port_key
>
>Which one seems more logical / reasonable?

	FWIW, I would go with ad_actor_sys_prio, ad_actor_system and
ad_user_port_key.  The first two then mimic the terms from the standard,
and the "user" one is part of the Actor_Admin_Port_Key from the
standard, so it follows the same sort of naming.

	-J

---
	-Jay Vosburgh, jay.vosburgh@canonical.com

      reply	other threads:[~2015-02-10  7:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07  0:51 [PATCH next 4/6] bonding: Allow userspace to set system_priority Mahesh Bandewar
2015-02-07  3:38 ` Andy Gospodarek
2015-02-07  6:19   ` Jay Vosburgh
2015-02-07 19:26     ` Mahesh Bandewar
2015-02-08  7:46       ` Jay Vosburgh
2015-02-09  5:44         ` Mahesh Bandewar
2015-02-10  7:05           ` Jay Vosburgh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28432.1423551917@famine \
    --to=jay.vosburgh@canonical.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@redhat.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.