Re: [dpdk-dev] [PATCH 1/2] common/octeontx2: move internal symbols to INTERNAL section

[Thomas Monjalon <thomas@monjalon.net>]

11/05/2020 12:00, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Move the internal symbols to INTERNAL sections so that any
> change in them is not reported as ABI breakage.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  drivers/common/octeontx2/otx2_common.h           |  8 ++++++++
>  drivers/common/octeontx2/otx2_dev.h              |  3 +++
>  drivers/common/octeontx2/otx2_irq.h              |  3 +++
>  drivers/common/octeontx2/otx2_mbox.h             |  6 ++++++
>  drivers/common/octeontx2/otx2_sec_idev.h         |  6 ++++++
>  .../octeontx2/rte_common_octeontx2_version.map   | 16 +++-------------
>  6 files changed, 29 insertions(+), 13 deletions(-)

You probably need to add an exception in libabigail.ignore file
for symbols moved from stable to internal.


> --- a/drivers/common/octeontx2/rte_common_octeontx2_version.map
> +++ b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> @@ -1,4 +1,4 @@
> -DPDK_20.0 {
> +INTERNAL {
>  	global:
>  
>  	otx2_dev_active_vfs;
> @@ -30,23 +30,13 @@ DPDK_20.0 {
>  	otx2_sso_pf_func_get;
>  	otx2_sso_pf_func_set;
>  	otx2_unregister_irq;
> -
> -	local: *;
> -};
> -
> -DPDK_21 {
> -	global:
> -
>  	otx2_eth_dev_is_sec_capable;
>  	otx2_sec_idev_cfg_init;
>  	otx2_sec_idev_tx_cpt_qp_add;
>  	otx2_sec_idev_tx_cpt_qp_remove;
>  	otx2_sec_idev_tx_cpt_qp_get;
>  	otx2_sec_idev_tx_cpt_qp_put;
> -} DPDK_20.0;
> -
> -EXPERIMENTAL {
> -	global:
> -
>  	otx2_logtype_ep;
> +
> +	local: *;
>  };

I think you should sort symbols in alphabetical way.