From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
jmorris@namei.org, roland@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rework/fix is_single_threaded()
Date: Thu, 09 Jul 2009 14:01:03 +0100 [thread overview]
Message-ID: <28464.1247144463@redhat.com> (raw)
In-Reply-To: <20090622192453.GA6066@redhat.com>
Oleg Nesterov <oleg@redhat.com> wrote:
> Unless David replies.
Sorry, I missed the last three messages.
> David, do you still dislike ->mmap_sem? I didn't see other objections,
> and again, imho tasklist_lock is worse.
My main objection to taking mmap_sem is that it restricts where the function
can be used. It can't, for example, be called by anyone holding a spinlock.
Furthermore, the more locks, the more chance of someone accidentally
deadlocking something.
But apart from that, go for it.
David
next prev parent reply other threads:[~2009-07-09 13:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 21:45 [PATCH] rework/fix is_single_threaded() Oleg Nesterov
2009-04-15 23:32 ` Andrew Morton
2009-04-16 13:40 ` Oleg Nesterov
2009-04-16 10:04 ` David Howells
2009-04-16 13:36 ` Oleg Nesterov
2009-04-16 14:36 ` Stephen Smalley
2009-04-16 14:54 ` Oleg Nesterov
2009-06-18 19:07 ` Andrew Morton
2009-06-18 19:42 ` Oleg Nesterov
2009-06-22 18:51 ` Andrew Morton
2009-06-22 17:14 ` Oleg Nesterov
2009-06-22 21:04 ` Andrew Morton
2009-06-22 19:24 ` Oleg Nesterov
2009-07-09 13:01 ` David Howells [this message]
2009-07-09 21:25 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28464.1247144463@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.