From: David Howells <dhowells@redhat.com>
To: graff.yang@gmail.com
Cc: dhowells@redhat.com, tj@kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu
Date: Mon, 22 Mar 2010 11:50:39 +0000 [thread overview]
Message-ID: <28495.1269258639@redhat.com> (raw)
In-Reply-To: <1268989324-7575-1-git-send-email-graff.yang@gmail.com>
<graff.yang@gmail.com> wrote:
> - return virt_to_page(addr);
> + return (struct page *)
> + (virt_to_page(addr)->index) ? : virt_to_page(addr);
Can the extra conditional operator be made subject to CONFIG_SMP?
> - return page_to_pfn(virt_to_page(addr));
> + return page_to_pfn((struct page *)
> + (virt_to_page(addr)->index) ? : virt_to_page(addr));
Ditto.
> +#ifdef CONFIG_SMP
> ...
> +#endif
Can this be put into a separate file? There's rather a lot in mm/nommu.c
these days.
David
next prev parent reply other threads:[~2010-03-22 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 9:02 [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu graff.yang
2010-03-20 4:06 ` Tejun Heo
2010-03-22 2:33 ` graff yang
2010-04-01 10:20 ` Tejun Heo
2010-04-06 9:28 ` Sonic Zhang
2010-04-08 2:43 ` Tejun Heo
2010-04-08 9:40 ` Sonic Zhang
2010-04-08 23:33 ` Tejun Heo
2010-03-22 4:14 ` [Uclinux-dist-devel] [PATCH] mm/nommu.c:Dynamic alloc/freepercpu " Zhang, Sonic
2010-03-22 11:50 ` David Howells [this message]
2010-03-23 2:33 ` [PATCH] mm/nommu.c:Dynamic alloc/free percpu " graff yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28495.1269258639@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=graff.yang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.