From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] FRV: Fix TLB miss mapping cache flush
Date: Wed, 30 Mar 2005 12:47:47 +0100 [thread overview]
Message-ID: <28499.1112183267@redhat.com> (raw)
The attached patch fixes the TLB miss mapping cache flush function.
The flush was attempting to invalidate the coverage start virtual addresses
for the cached page table mappings held in registers SCR0 and SCR1 by writing
0 into them. Unfortunately, 0x00000000-0x04000000 is itself a valid part of
the virtual address range. This patches places -1 in there instead, thus
specifying 0xfc000000-0xffffffff which is covered by a static I/O mapping, and
so shouldn't ever be seen by the TLB-miss handler.
Signed-Off-By: David Howells <dhowells@redhat.com>
---
warthog>diffstat -p1 frv-tlbmiss-2612rc1.diff
include/asm-frv/tlbflush.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -uNrp /warthog/kernels/linux-2.6.12-rc1/include/asm-frv/tlbflush.h linux-2.6.12-rc1-frv-tlbmiss/include/asm-frv/tlbflush.h
--- /warthog/kernels/linux-2.6.12-rc1/include/asm-frv/tlbflush.h 2005-03-02 12:08:45.000000000 +0000
+++ linux-2.6.12-rc1-frv-tlbmiss/include/asm-frv/tlbflush.h 2005-03-30 11:50:06.000000000 +0100
@@ -58,7 +58,8 @@ do { \
#define __flush_tlb_global() flush_tlb_all()
#define flush_tlb() flush_tlb_all()
#define flush_tlb_kernel_range(start, end) flush_tlb_all()
-#define flush_tlb_pgtables(mm,start,end) asm volatile("movgs gr0,scr0 ! movgs gr0,scr1");
+#define flush_tlb_pgtables(mm,start,end) \
+ asm volatile("movgs %0,scr0 ! movgs %0,scr1" :: "r"(ULONG_MAX) : "memory");
#else
reply other threads:[~2005-03-30 11:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28499.1112183267@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.