From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 20.05] ethdev: clear struct on releasing port
Date: Thu, 13 Feb 2020 16:27:53 +0100 [thread overview]
Message-ID: <2855847.M6yMPqc0BA@xps> (raw)
In-Reply-To: <5ba0db1f-f530-f25f-b9fa-521ed9921c7e@intel.com>
13/02/2020 16:16, Ferruh Yigit:
> On 2/13/2020 2:33 PM, Thomas Monjalon wrote:
> > The function rte_eth_dev_release_port() is called by drivers
> > when closing or removing a device.
> > Its main usage should be via rte_eth_dev_close() by up-to-date
> > drivers which are compliant with RTE_ETH_DEV_CLOSE_REMOVE flag.
> >
> > When a port is released, the data (rte_eth_dev_data) are cleared,
> > but the pointers in rte_eth_dev were not cleared.
> > It may cause issues with code paths trying to use dangling pointers
> > (e.g. the .device pointer which may reference a removed rte_device).
> > Everything is now cleared to 0 when releasing.
> > The state is explicitly set to RTE_ETH_DEV_UNUSED which is 0 anyway.
> >
> > Using this patch may reveal bugs in some code paths:
> > - device pointer must be saved before closing a port if needed
>
> Is this saving should be done in application code or will be done by ethdev?
by the application
From ethdev point of view, when a port is closed, there is nothing more to do next.
next prev parent reply other threads:[~2020-02-13 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:33 [dpdk-dev] [PATCH 20.05] ethdev: clear struct on releasing port Thomas Monjalon
2020-02-13 15:16 ` Ferruh Yigit
2020-02-13 15:27 ` Thomas Monjalon [this message]
2020-02-13 16:05 ` Ferruh Yigit
2020-02-13 19:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2855847.M6yMPqc0BA@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.