From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 05 Dec 2017 20:28:11 +0000 Subject: [PATCH 2/4] uwb: Delete an error message for a failed memory allocation in whcrc_probe() Message-Id: <2857ba10-caa2-b283-da10-e292fdc8698d@users.sourceforge.net> List-Id: References: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> In-Reply-To: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-usb@vger.kernel.org, Andrey Konovalov , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 5 Dec 2017 20:43:31 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/whc-rc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/uwb/whc-rc.c b/drivers/uwb/whc-rc.c index 3ae3c702500d..f69511166aad 100644 --- a/drivers/uwb/whc-rc.c +++ b/drivers/uwb/whc-rc.c @@ -374,10 +374,9 @@ int whcrc_probe(struct umc_dev *umc_dev) goto error_rc_alloc; } whcrc = kzalloc(sizeof(*whcrc), GFP_KERNEL); - if (whcrc = NULL) { - dev_err(dev, "unable to allocate WHC-RC instance\n"); + if (!whcrc) goto error_alloc; - } + whcrc_init(whcrc); whcrc->umc_dev = umc_dev; -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbdLEU2V (ORCPT ); Tue, 5 Dec 2017 15:28:21 -0500 Received: from mout.web.de ([212.227.15.14]:51954 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbdLEU2S (ORCPT ); Tue, 5 Dec 2017 15:28:18 -0500 Subject: [PATCH 2/4] uwb: Delete an error message for a failed memory allocation in whcrc_probe() From: SF Markus Elfring To: linux-usb@vger.kernel.org, Andrey Konovalov , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org References: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Message-ID: <2857ba10-caa2-b283-da10-e292fdc8698d@users.sourceforge.net> Date: Tue, 5 Dec 2017 21:28:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:y3zBOn9ZGfiwlMqm3WmtEfvm6XsN+plO9TyxliD+1EvfyXIEw8L EnKf7agxmFSMClciBQAy/WGmefaSEAbJOAgcwlVucMadDE/VCAyjyQZ37/sZosOMsQFTYkD 6Arl6sKvmeSxfGC2RjedyYuIfe6tTZRmEtgzrhVfG9AMidRYUvcqJPBZxLhm68+fiyHM8hg D/LXJoGAJx/SWhlKA2vow== X-UI-Out-Filterresults: notjunk:1;V01:K0:kYSUC3OFP+k=:EAToAHUhNBIhvuuv9Q/Hke nQvsElkVdU5q/IQoWmGu1aTgDwB61oWuGVXkpa0n/WxAXhmU7uADXlWTDDayHYFraoR7O4uvy q6D3Za24I2mWurAX0TWA2g9xVrmUPuga7czhCrJVcQEv4wHdxmixetZ2UF201lCEfj9aQ3jL3 s8yQjlvFUGGt+4FZqbVmrGUwQiYtvCMHyqaEj0i92xx4eREEpqmCn4tA3ODAx8QIc3V6STdmQ q2SN7Ozgo0+RRR7ep+oPAI61laMpTQEl4rfrZtphHX8wWbZ+okpz/VrU3Zwc8EYDdt3Ssqrjf wVaG5q0NgKyrUutAoj/z2owrb6xqVszF1k1htwzen8joGkzigl6ugJ//8UxGMLu7PWU+Vjagi 2ejMRjXrZWPBeZSDsDvm65eQjuz3nWoPYU8MD5sJ8D/+G46pXwmy7EAfPuyh05bCdz/ZlA9uP g5ibVFqhnSZ6Y5lT046OTZlijmM+mLOrkZrI1J615KK+WxUFeiNS9xfJb5gUrCxtq456DIGEa s75RgrKtaaEHlo/9s0nru1robngzAW9ObAhdc3r3R2cGTUoNppZ7vehYJD2jcD07VWBp12M+N Ylte2EPO5beqSJja2h6bTP/YlLuVeu1GN5+a00RBEw1NRP4dH0VO1bZLv57oyHhLaPozTckzB fnU9q/1OR9ZRU9fw74UjG7vcoqdIhiFMI2Y4SdyHO1GgeXs2r2lXMrgNkYWtAGFQtz3YOJTKL q3O8AMKiMvLDNWZzXAj2bwYdxfcodkY4dZtJ2So2sXSznNcsRY5WPg+9hBhuztCGqG4xSto5a xdWQ7+RahCYG5MCe+F6NsqL9tRVhoPOOjdOwC7n/mC4YoehXIU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Dec 2017 20:43:31 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/whc-rc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/uwb/whc-rc.c b/drivers/uwb/whc-rc.c index 3ae3c702500d..f69511166aad 100644 --- a/drivers/uwb/whc-rc.c +++ b/drivers/uwb/whc-rc.c @@ -374,10 +374,9 @@ int whcrc_probe(struct umc_dev *umc_dev) goto error_rc_alloc; } whcrc = kzalloc(sizeof(*whcrc), GFP_KERNEL); - if (whcrc == NULL) { - dev_err(dev, "unable to allocate WHC-RC instance\n"); + if (!whcrc) goto error_alloc; - } + whcrc_init(whcrc); whcrc->umc_dev = umc_dev; -- 2.15.1