From: Michael Neuling <mikey@neuling.org>
To: Sonny Rao <sonnyrao@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
acme@redhat.com, anton@samba.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] perf: robustify proc and debugfs file recording
Date: Thu, 14 Jul 2011 10:18:05 +1000 [thread overview]
Message-ID: <28585.1310602685@neuling.org> (raw)
In-Reply-To: <CAPz6YkW_iHA26+aDBrbiUOKSa_kXuVxO-uiuShHVO89cniS+vw@mail.gmail.com>
> >>> + if (pwrite(output_fd, &size, hdr_sz, hdr_pos) < 0)
> >>
> >> s/&size/sizep/
> >
> > Argh, I'm really messing this up... so yeah this shouldn't have worked
> > on big-endian without that fix..
> > Mikey, are you sure it worked?
>
> Actually, I think you need to use tracepoints or this code won't be invoked=
> .
> So, please try with some tracepoints, thanks.
Yeah, with tracepoints it's broken.
With Steven fix though it's all good on my powerpc box.
Mikey
next prev parent reply other threads:[~2011-07-14 0:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:15 [PATCH] [RFC] perf: robustify proc and debugfs file recording Sonny Rao
2011-07-12 21:19 ` Sonny Rao
2011-07-12 22:56 ` Steven Rostedt
2011-07-12 23:01 ` Sonny Rao
2011-07-12 23:29 ` Steven Rostedt
2011-07-13 10:39 ` Michael Neuling
2011-07-13 10:52 ` Michael Neuling
2011-07-13 17:45 ` Sonny Rao
2011-07-13 20:38 ` Steven Rostedt
2011-07-13 20:49 ` Sonny Rao
2011-07-13 20:58 ` Sonny Rao
2011-07-14 0:18 ` Michael Neuling [this message]
2011-07-14 0:40 ` [PATCH] [RFCv2] " Sonny Rao
2011-07-14 2:57 ` Steven Rostedt
2011-07-14 3:34 ` [PATCH] [RFCv3] " Michael Neuling
2011-07-14 12:45 ` Steven Rostedt
2011-07-14 12:55 ` Peter Zijlstra
2011-07-14 13:24 ` Steven Rostedt
2011-07-14 21:38 ` Michael Neuling
2011-07-14 21:54 ` Steven Rostedt
2011-07-14 22:03 ` Sonny Rao
2011-07-21 9:59 ` [tip:perf/core] perf: Robustify " tip-bot for Sonny Rao
2011-07-13 16:50 ` [RFC] perf: robustify " Riccardo Magliocchetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28585.1310602685@neuling.org \
--to=mikey@neuling.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.