Re: [PATCH] devtools: fix bad substitution

[Thomas Monjalon <thomas@monjalon.net>]

11/07/2023 09:16, Raslan Darawsheh:
> When running check-git-log, it showed a Bad substitution.
> 
> It is fixed by using tr to escape the open parenthesis.
> 
> Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")
> Cc: thomas@monjalon.net
> 
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
>  devtools/check-git-log.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
> index 89544a2cc5..5c869b7683 100755
> --- a/devtools/check-git-log.sh
> +++ b/devtools/check-git-log.sh
> @@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
>  	sed -rn 's,.*: (.*<.*@.*>),\1,p' |
>  	sort -u)
>  bad=$(for contributor in $names ; do
> -	contributor=${contributor//(/\\(}
> +	contributor=$(echo $contributor | tr '(' '\\(')

tr was not working here, replaced with sed

Applied, thanks.