All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Taylor <sol10x86@cox.net>
To: Lennert Buytenhek <buytenh@wantstofly.org>, qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] patch for supporting SMB on Solaris host
Date: Sat, 23 Dec 2006 8:17:47 -0500	[thread overview]
Message-ID: <28670974.1166879867726.JavaMail.root@eastrmwml07.mgt.cox.net> (raw)


---- Lennert Buytenhek <buytenh@wantstofly.org> wrote: 
> On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote:
> 
> > -    snprintf(smb_cmdline, sizeof(smb_cmdline), "/usr/sbin/smbd -s %s",
> > -             smb_conf);
> > +    snprintf(smb_cmdline, sizeof(smb_cmdline), "% -s %s",
> > +             SMBD_BINARY, smb_conf);
> 
> Doesn't look right to me?  (s/%/%s/)

Good catch.   otherwise, the patch is better?

Ben

             reply	other threads:[~2006-12-23 13:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-23 13:17 Ben Taylor [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-23  1:40 [Qemu-devel] patch for supporting SMB on Solaris host Ben Taylor
2006-12-23  1:40 Ben Taylor
2006-12-23  1:48 ` Lennert Buytenhek
2006-12-23  0:06 Ben Taylor
2006-12-22 20:07 Ben Taylor
2006-12-22 21:29 ` Paul Brook
2006-12-22 21:32   ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28670974.1166879867726.JavaMail.root@eastrmwml07.mgt.cox.net \
    --to=sol10x86@cox.net \
    --cc=buytenh@wantstofly.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.