From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Gy6l3-0005q3-QH
	for qemu-devel@nongnu.org; Sat, 23 Dec 2006 08:17:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Gy6l2-0005nT-Sh
	for qemu-devel@nongnu.org; Sat, 23 Dec 2006 08:17:49 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Gy6l2-0005n7-DH
	for qemu-devel@nongnu.org; Sat, 23 Dec 2006 08:17:48 -0500
Received: from [70.168.83.78] (helo=centrmmtao06.cox.net)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gy6l2-0002JH-2x
	for qemu-devel@nongnu.org; Sat, 23 Dec 2006 08:17:48 -0500
Message-ID: <28670974.1166879867726.JavaMail.root@eastrmwml07.mgt.cox.net>
Date: Sat, 23 Dec 2006 8:17:47 -0500
From: Ben Taylor <sol10x86@cox.net>
Subject: Re: [Qemu-devel] patch for supporting SMB on Solaris host
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Reply-To: sol10x86@cox.net, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lennert Buytenhek <buytenh@wantstofly.org>, qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>


---- Lennert Buytenhek <buytenh@wantstofly.org> wrote: 
> On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote:
> 
> > -    snprintf(smb_cmdline, sizeof(smb_cmdline), "/usr/sbin/smbd -s %s",
> > -             smb_conf);
> > +    snprintf(smb_cmdline, sizeof(smb_cmdline), "% -s %s",
> > +             SMBD_BINARY, smb_conf);
> 
> Doesn't look right to me?  (s/%/%s/)

Good catch.   otherwise, the patch is better?

Ben