All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Paul Moore <paul@paul-moore.com>, linux-audit@redhat.com
Cc: Linux-audit@redhat.com
Subject: Re: Key based rate limiter (audit_set_rate_limit)
Date: Wed, 08 Mar 2023 10:51:13 -0500	[thread overview]
Message-ID: <2878938.e9J7NaK4W3@x2> (raw)
In-Reply-To: <CAPoNrtvt_RZfPYLAWdPp6gTu_67f1RzOz3s4T62SdoG4ryyzGw@mail.gmail.com>

On Wednesday, March 8, 2023 6:53:39 AM EST Anurag Aggarwal wrote:
> > Limiting of audit records is actually done in the kernel, and
> > currently the rate limit applies equally[1] to all records, there is
> > no ability to enforce limits per-key.
> 
> One question Paul, will it be ok, if we contribute something similar to the
> Auditd Kernel repository?

I'm not Paul...but I think what you are proposing is a per rule service
class. Always and best effort where best effort gets discarded when the
backlog is above some heuristic. And rules not saying anything are assumed 
always for backwards compatibility. The main issue is that rules are defined
here:

https://github.com/linux-audit/audit-kernel/blob/main/include/uapi/linux/
audit.h#L510

There just really isn't room to add more thinkgs without some userspace API 
problem. (This would definitely need a feaure bitmap so user space can make 
sense of it.)

I suppose we could declare some bits in flags to carry this meaning? Anyways, 
maybe others might chime in to say if they want/need such a feature.

-Steve


--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2023-03-08 15:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 10:53 Key based rate limiter (audit_set_rate_limit) Anurag Aggarwal
2023-02-28 14:11 ` Paul Moore
2023-02-28 15:35   ` Anurag Aggarwal
2023-02-28 16:31     ` Paul Moore
2023-02-28 17:03       ` Lenny Bruzenak
2023-03-01 15:31         ` Anurag Aggarwal
2023-03-01 17:05           ` Lenny Bruzenak
2023-03-02  5:13             ` Anurag Aggarwal
2023-03-02 17:24               ` Lenny Bruzenak
2023-03-02 19:11                 ` Paul Moore
2023-03-06  5:48                   ` Anurag Aggarwal
2023-03-08 11:53   ` Anurag Aggarwal
2023-03-08 15:51     ` Steve Grubb [this message]
2023-03-08 17:04     ` Paul Moore
2023-03-09  6:16       ` Anurag Aggarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2878938.e9J7NaK4W3@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.