All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
	Solal Pirelli <solal.pirelli@epfl.ch>,
	solal.pirelli@gmail.com
Subject: Re: [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases
Date: Mon, 02 Apr 2018 18:50:12 +0200	[thread overview]
Message-ID: <2880455.xF8ZZNx2Pu@xps> (raw)
In-Reply-To: <20180402120619.30404-1-nhorman@tuxdriver.com>

02/04/2018 14:06, Neil Horman:
> https://dpdk.org/tracker/show_bug.cgi?id=18

I really appreciate reading such bug request.
Maybe we should add a Suggested-by line
	Suggested-by: Solal Pirelli <solal.pirelli@gmail.com>
before the SoB line (chronological order).


> Indicated that several mmap call sites in the linuxapp eal code used an
> fd that was not -1 in their calls while using MAP_ANONYMOUS.  While
> probably not a huge deal, the man page does say the fd should be -1 for
> portability, as some implementations don't ignore fd as they should for
> MAP_ANONYMOUS, and seting -1 here allows us to eliminate some code.
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: Ferruh Yigit <ferruh.yigit@intel.com>

  reply	other threads:[~2018-04-02 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 12:06 [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases Neil Horman
2018-04-02 16:50 ` Thomas Monjalon [this message]
2018-04-02 19:32   ` Neil Horman
2018-04-11 22:27 ` Thomas Monjalon
2018-04-12 11:16 ` [PATCHv2] " Neil Horman
2018-04-12 12:05   ` Burakov, Anatoly
2018-04-12 12:40     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2880455.xF8ZZNx2Pu@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=solal.pirelli@epfl.ch \
    --cc=solal.pirelli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.