From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:53379 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbcFUJO7 (ORCPT ); Tue, 21 Jun 2016 05:14:59 -0400 From: Laurent Pinchart To: Chris Wilson Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , David Airlie , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all() Date: Tue, 21 Jun 2016 12:15:17 +0300 Message-ID: <2881992.mZhRLFloE1@avalon> In-Reply-To: <1466151923-1572-8-git-send-email-chris@chris-wilson.co.uk> References: <1466151923-1572-1-git-send-email-chris@chris-wilson.co.uk> <1466151923-1572-8-git-send-email-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Chris, Thank you for the patch. On Friday 17 Jun 2016 09:25:23 Chris Wilson wrote: > Up to now, the recommendation was for drivers to call drm_dev_register() > followed by drm_connector_register_all(). Now that > drm_connector_register() is safe against multiple invocations, we can > move drm_connector_register_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 48ec4b6e8b26..36d390093c92 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -278,7 +278,6 @@ static int rcar_du_remove(struct platform_device *pdev) > struct rcar_du_device *rcdu = platform_get_drvdata(pdev); > struct drm_device *ddev = rcdu->ddev; > > - drm_connector_unregister_all(ddev); > drm_dev_unregister(ddev); > > if (rcdu->fbdev) > @@ -360,10 +359,6 @@ static int rcar_du_probe(struct platform_device *pdev) > if (ret) > goto error; > > - ret = drm_connector_register_all(ddev); > - if (ret < 0) > - goto error; > - > DRM_INFO("Device %s probed\n", dev_name(&pdev->dev)); > > return 0; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all() Date: Tue, 21 Jun 2016 12:15:17 +0300 Message-ID: <2881992.mZhRLFloE1@avalon> References: <1466151923-1572-1-git-send-email-chris@chris-wilson.co.uk> <1466151923-1572-8-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466151923-1572-8-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXMsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIEZyaWRheSAxNyBKdW4gMjAx NiAwOToyNToyMyBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gVXAgdG8gbm93LCB0aGUgcmVjb21tZW5k YXRpb24gd2FzIGZvciBkcml2ZXJzIHRvIGNhbGwgZHJtX2Rldl9yZWdpc3RlcigpCj4gZm9sbG93 ZWQgYnkgZHJtX2Nvbm5lY3Rvcl9yZWdpc3Rlcl9hbGwoKS4gTm93IHRoYXQKPiBkcm1fY29ubmVj dG9yX3JlZ2lzdGVyKCkgaXMgc2FmZSBhZ2FpbnN0IG11bHRpcGxlIGludm9jYXRpb25zLCB3ZSBj YW4KPiBtb3ZlIGRybV9jb25uZWN0b3JfcmVnaXN0ZXJfYWxsKCkgdG8gZHJtX2Rldl9yZWdpc3Rl cigpIGFuZCBub3Qgc3VmZmVyCj4gZnJvbSBhbnkgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgaXNz dWVzIHdpdGggZHJpdmVycyBub3QgZm9sbG93aW5nIHRoZQo+IG1vcmUgcmlnb3JvdXMgaW5pdCBv cmRlcmluZy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29t Pgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogbGludXgtcmVuZXNhcy1zb2NAdmdlci5rZXJuZWwu b3JnCgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVh c29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9k cnYuYyB8IDUgLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiBiL2RyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgaW5kZXggNDhlYzRiNmU4YjI2Li4zNmQz OTAwOTNjOTIKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBA IC0yNzgsNyArMjc4LDYgQEAgc3RhdGljIGludCByY2FyX2R1X3JlbW92ZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ICAJc3RydWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1ID0gcGxhdGZv cm1fZ2V0X2RydmRhdGEocGRldik7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGRldiA9IHJjZHUt PmRkZXY7Cj4gCj4gLQlkcm1fY29ubmVjdG9yX3VucmVnaXN0ZXJfYWxsKGRkZXYpOwo+ICAJZHJt X2Rldl91bnJlZ2lzdGVyKGRkZXYpOwo+IAo+ICAJaWYgKHJjZHUtPmZiZGV2KQo+IEBAIC0zNjAs MTAgKzM1OSw2IEBAIHN0YXRpYyBpbnQgcmNhcl9kdV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVycm9yOwo+IAo+IC0JcmV0ID0gZHJt X2Nvbm5lY3Rvcl9yZWdpc3Rlcl9hbGwoZGRldik7Cj4gLQlpZiAocmV0IDwgMCkKPiAtCQlnb3Rv IGVycm9yOwo+IC0KPiAgCURSTV9JTkZPKCJEZXZpY2UgJXMgcHJvYmVkXG4iLCBkZXZfbmFtZSgm cGRldi0+ZGV2KSk7Cj4gCj4gIAlyZXR1cm4gMDsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==