All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>,
	Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>,
	Magnus <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: HDMI doesn't work on ULCB board
Date: Sat, 10 Nov 2018 10:51:30 +0200	[thread overview]
Message-ID: <2882874.cFkjQ8NM4n@avalon> (raw)
In-Reply-To: <87o9azj8tq.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Friday, 9 November 2018 04:23:36 EET Kuninori Morimoto wrote:
> Hi Laurent
> 
> >>> I tried to reproduce the problem, starting with drm-next which seems
> >>> to work fine, moving to renesas-drivers-2018-10-09-v4.19-rc7 which
> >>> also didn't exhibit any issue. I then used your kernel configuration,
> >>> and got a WARN_ON \o/
> >> 
> >> Investigations revealed that you're missing the CONFIG_COMMON_CLK_VC5=y
> >> option in your kernel configuration. It also revealed a bug in the
> >> error handling code of the DU driver, for which I have just sent
> >> "[PATCH] drm: rcar-du: Fix external clock error checks".
> > 
> > Thanks !!
> > I tried your posted patch, and it solved Oops issue,
> > and CONFIG_COMMON_CLK_VC5 solved HDMI outputs !!
> 
> Hmm...
> 
> I noticed Salvator can't boot if .config has CONFIG_COMMON_CLK_VC5.
> This means, Salvator and ULCB can't use same binary so far for me
> (= all modules are =y on .config).
> I'm using previous attached .config + your patch + CONFIG_COMMON_CLK_VC5
> 
> Kernel will stop here on Salvator
> 
> -----------------
> ....
> rcar-fcp fe9af000.fcp: ignoring dependency for device, assuming no driver
> rcar-fcp fe9bf000.fcp: ignoring dependency for device, assuming no driver
> rcar-fcp fea27000.fcp: ignoring dependency for device, assuming no driver
> rcar-fcp fea2f000.fcp: ignoring dependency for device, assuming no driver
> rcar-fcp fea37000.fcp: ignoring dependency for device, assuming no driver
> [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> [drm] No driver support for vblank timestamp query.
> 
> 	** stop here **

I'm afraid I can't reproduce this. I checked out renesas-drivers-2018-10-09-
v4.19-rc7, applied the fix I've submitted, took your configuration, enabled 
CONFIG_COMMON_CLK_VC5, and my Salvator-XS H3 boots fine.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-11-10 18:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bm7svwmp.wl-kuninori.morimoto.gx@renesas.com>
2018-10-19 13:32 ` HDMI doesn't work on ULCB board Laurent Pinchart
2018-10-29  1:07   ` Kuninori Morimoto
2018-11-06 14:30 ` Laurent Pinchart
2018-11-06 15:40   ` Laurent Pinchart
2018-11-08  0:16     ` Kuninori Morimoto
2018-11-09  2:23       ` Kuninori Morimoto
2018-11-10  8:51         ` Laurent Pinchart [this message]
2018-11-12  3:09           ` Kuninori Morimoto
2018-11-12  3:23             ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2882874.cFkjQ8NM4n@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=vladimir.barinov+renesas@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.