From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: testpmd could not start up with vmxnet3 port
Date: Wed, 23 Mar 2016 16:55:43 +0100
Message-ID: <2884173.JGZgsZNF00@xps13>
References: <6EBE0505FB6FBE47AB600802285284524B853B86@CDSMSX101.ccr.corp.intel.com>
 <82F45D86ADE5454A95A89742C8D1410E0320E103@shsmsx102.ccr.corp.intel.com>
 <835F13EC-4482-40D1-8A38-F994B82EC68E@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "Xu, Qian Q" <qian.q.xu@intel.com>, "Ding,
 HengX" <hengx.ding@intel.com>, Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 1D90B2C09
 for <dev@dpdk.org>; Wed, 23 Mar 2016 16:57:26 +0100 (CET)
Received: by mail-wm0-f45.google.com with SMTP id l68so240076439wml.0
 for <dev@dpdk.org>; Wed, 23 Mar 2016 08:57:26 -0700 (PDT)
In-Reply-To: <835F13EC-4482-40D1-8A38-F994B82EC68E@vmware.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-23 05:57, Yong Wang:
> From: Ding, HengX
> > Testpmd will fail to start up with vmxnet3 port.
[...]
> Currently vmxnet3=E2=80=99s default_txconf.txq_flags is set to the fo=
llowing, which is used by testpmd
> as there is no explicit txconf passed when initializing tx queue:
>=20
>         dev_info->default_txconf.txq_flags =3D ETH_TXQ_FLAGS_NOMULTSE=
GS |
>                                                 ETH_TXQ_FLAGS_NOOFFLO=
ADS;

In vmxnet3_dev_tx_queue_setup:
    if ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOXSUMS) !=3D
        ETH_TXQ_FLAGS_NOXSUMSCTP) {
        PMD_INIT_LOG(ERR, "SCTP checksum offload not supported");
        return -EINVAL;
    }
It means we cannot disable TCP or UDP checksum offload.
ETH_TXQ_FLAGS_NOXSUMS =3D NOXSUMSCTP + NOXSUMUDP + NOXSUMTCP

I think it should be:
    if ((tx_conf->txq_flags & ETH_TXQ_FLAGS_NOXSUMSCTP) !=3D
        ETH_TXQ_FLAGS_NOXSUMSCTP) {

> With the referred patch that introduced l4 cksum offload, we should u=
pdate the default txq
> flags check accordingly.  Heng, can you post the error logs to confir=
m this is indeed the cause
> of the error you reported?

The default conf is ETH_TXQ_FLAGS_NOOFFLOADS (=3D NOVLANOFFL + NOXSUMS)=
.
Yes you can update the default conf, *and* fix the check above.

> Related to this, I saw that the check for NOMULTISEGS has been remove=
d and the check for
> NOVLANOFF was never implemented.  Should we just remove the offload f=
lags check as well
> as I don=E2=80=99t see much value of this check.  Basically we know t=
hat the device does not support
> certain offload and we have to set those flags to let the device init=
ialize. But doing this does
> nothing to prevent users to request these non-supported offload.  I a=
lso saw another thread
> discussing better device capability APIs and hopefully this will not =
be needed then

These checks are important to throw an error if an offload is requested=

but not supported.