All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [GIT PULL for v4.1] smiapp DT u64 property workaround removal
Date: Sun, 08 Mar 2015 01:22:02 +0200	[thread overview]
Message-ID: <2889029.OECMz0WOKz@avalon> (raw)
In-Reply-To: <20150307232040.GF6539@valkosipuli.retiisi.org.uk>

Hi Sakari,

On Sunday 08 March 2015 01:20:40 Sakari Ailus wrote:
> On Sun, Mar 08, 2015 at 01:15:38AM +0200, Laurent Pinchart wrote:
> > > Sakari Ailus (2):
> > >       Revert "[media] smiapp: Don't compile of_read_number() if
> > >       CONFIG_OF isn't defined"
> > >       smiapp: Use of_property_read_u64_array() to read a 64-bit number
> > >       array
> > 
> > Won't this cause a bisection breakage if CONFIG_OF isn't enabled ?
> 
> Technically you're right: it does "break" bisect if smiapp is compiled in on
> a non-DT platform. Such a platform is not supported in a mainline kernel so
> I don't think this is a really major issue.
> 
> I could combine the patches if you think this is an issue.

It would break bisection with allmodconfig on non-DT platforms for instance. I 
think combining the two patches would make sense.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-03-07 23:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 22:06 [GIT PULL for v4.1] smiapp DT u64 property workaround removal Sakari Ailus
2015-03-07 23:15 ` Laurent Pinchart
2015-03-07 23:20   ` Sakari Ailus
2015-03-07 23:22     ` Laurent Pinchart [this message]
2015-03-07 23:29       ` [GIT PULL v2 " Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2889029.OECMz0WOKz@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.