From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/43] drm/i915: Do a synchronous switch-to-kernel-context on idling Date: Fri, 8 Mar 2019 06:46:52 +0000 Message-ID: <289293e2-e074-8b19-b42e-ff42ddf31a26@linux.intel.com> References: <20190306142517.22558-1-chris@chris-wilson.co.uk> <20190306142517.22558-5-chris@chris-wilson.co.uk> <155196537784.27405.13370733676669351992@skylake-alporthouse-com> <155199746951.27405.6347253824738599537@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5129489B00 for ; Fri, 8 Mar 2019 06:46:55 +0000 (UTC) In-Reply-To: <155199746951.27405.6347253824738599537@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: matthew.auld@intel.com List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzAzLzIwMTkgMjI6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTA3IDE3OjA2OjU4KQo+Pgo+PiBPbiAwNy8wMy8yMDE5IDEzOjI5 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTAz LTA3IDEzOjA3OjE4KQo+Pj4+Cj4+Pj4gT24gMDYvMDMvMjAxOSAxNDoyNCwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiArc3RhdGljIGJvb2wgc3dpdGNoX3RvX2tlcm5lbF9jb250ZXh0X3N5bmMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgIGlmIChp OTE1X2dlbV9zd2l0Y2hfdG9fa2VybmVsX2NvbnRleHQoaTkxNSkpCj4+Pj4+ICsgICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwo+Pj4+Cj4+Pj4gSXMgaXQgd29ydGggc3RpbGwgdHJ5aW5nIHRvIGlk bGUgaWYgdGhpcyBmYWlscz8gU2luY2UgdGhlIHRpbWVvdXQgaXMKPj4+PiBzaG9ydCwgbWF5YmUg cmVzZXQgaW4gaWRsZSBzdGF0ZSBicmluZyBsZXNzIGhhdm9jIHRoYW4gbm90LiBJdCBjYW4gb25s eQo+Pj4+IGZhaWwgb24gbWVtb3J5IGFsbG9jYXRpb25zIEkgdGhpbmssIG9rYXkgYW5kIHRlcm1p bmFsbHkgd2VkZ2VkLiBJbiB3aGljaAo+Pj4+IGNhc2UgaXQgaXMgc3RpbGwgb2theS4KPj4+Cj4+ PiBUZXJtaW5hbGx5IHdlZGdlZCBpcyBoYXJkIHdpcmVkIHRvIHJldHVybiAwICh0aGlzLCB0aGUg bmV4dCBwYXRjaD8pIHNvCj4+PiB0aGF0IHdlIGRvbid0IGJhaWwgZHVyaW5nIGk5MTVfZ2VtX3N1 c3BlbmQoKSBmb3IgdGhpcyByZWFzb24uCj4+Pgo+Pj4gV2UgZG8gc3RpbGwgaWRsZSBpZiB0aGlz IGZhaWxzLCBhcyB3ZSBtYXJrIHRoZSBkcml2ZXIvR1BVIGFzIHdlZGdlZC4KPj4+IFBlcmZvcm0g YSBHUFUgcmVzZXQgc28gdGhhdCBpdCBob3BlZnVsbHkgaXNuJ3Qgc2hvb3Rpbmcga2l0dGVucyBh bnkKPj4+IG1vcmUsIGFuZCBwdWxsIGEgcGlsbG93IG92ZXIgb3VyIGhlYWRzLgo+Pgo+PiBJIGRp ZG4ndCBmaW5kIGEgcGF0aCB3aGljaCBpZGxlcyBiZWZvcmUgd2VkZ2luZyBpZgo+PiBzd2l0Y2hf dG9fa2VybmVsX2NvbnRleHRfc3luYyBmYWlscyBkdWUgZmFpbGluZwo+PiBpOTE1X2dlbV9zd2l0 Y2hfdG9fa2VybmVsX2NvbnRleHQuIFdoZXJlIGlzIGl0Pwo+IAo+IFdlZGdpbmcgaW1wbGllcyBp ZGxpbmcuIFdoZW4gd2UgYXJlIHdlZGdlZCwgdGhlIEdQVSBpcyByZXNldCBhbmQgbGVmdAo+IHBv aW50aW5nIGludG8gdGhlIHZvaWQgKGVmZmVjdGl2ZWx5IGlkbGUsIEdUIHBvd2Vyc2F2aW5nIHNo b3VsZCBiZQo+IHVuYWZmZWN0ZWQgYnkgdGhlIHdlZGdlLCBkb24ndCBhc2sgaG93IHRoYXQgd29y a3Mgb24gaWxrKS4gQWxsIHRoZQo+IGNhbGxlcnMgZG8KPiAKPiBpZiAoIXN3aXRjaF90b19rZXJu ZWxfY29udGV4dF9zeW5jKCkpCj4gCWk5MTVfZ2VtX3NldF93ZWRnZWQoKQo+IAo+IHdpdGggbW9y ZSBvciBsZXNzIGludGVybWVkaWF0ZSBzdGVwcy4gSG1tLCBnaXZlbiB0aGF0IGlzIHRydWUgd2h5 IG5vdAo+IHB1bGwgaXQgaW50byBzd2l0Y2hfdG9fa2VybmVsX2NvbnRleHRfc3luYygpLi4uCgpJ ZiBhbGwgY2FsbGVycyBmb2xsb3cgdXAgd2l0aCBhIHdlZGdlIG1heWJlLCB5ZXMuCgo+IAo+PiBJ dCBpcyBhIG1pbm9yIGNvbmNlcm4gZG9uJ3QgZ2V0IG1lIHdyb25nLiBJdCBpcyB1bmxpa2VseSB0 byBmYWlsIGxpa2UKPj4gdGhpcy4gSSB3YXMgc2ltcGx5IHRoaW5raW5nIHdoeSBub3QgdHJ5IGFu ZCB3YWl0IGZvciB0aGUgY3VycmVudCB3b3JrIHRvCj4+IGZpbmlzaCBiZWZvcmUgc3VzcGVuZGlu ZyBpbiB0aGlzIGNhc2UuIE1pZ2h0IGJlIGEgYmV0dGVyIGV4cGVyaWVuY2UKPj4gYWZ0ZXIgcmVz dW1lLgo+IAo+IEZvciB0aGUgZGVza3RvcCB1c2UgY2FzZSwgaXQncyBpbW1hdGVyaWFsIGFzIHRo ZSBob3RwbHVnLCByZWNvbmZpZ3VyZQo+IGFuZCByZWRyYXcgdGFrZSBjYXJlIG9mIHRoYXQuIChG YmNvbiBpcyBhbHNvIGNsZWFyZWQuKQoKQnV0IGEgbWF0dGVyIG9mIHdoZXRoZXIgY29udGV4dCBz dGF0ZSBpcyBzYW5lIG9yIGNvcnJ1cHQgSSB0aGluayBjb21lcyAKaW50byBwbGF5LiBBIHNob3J0 IHdhaXQgZm9yIGlkbGUgYmVmb3JlIHN1c3BlbmQgbWlnaHQgc3RpbGwgd29yayBpZiB0aGUgCmV4 dHJlbWVseSB1bmxpa2VseSBmYWlsIGluIGk5MTVfZ2VtX3N3aXRjaF90b19rZXJuZWxfY29udGV4 dCBoYXBwZW5zLgoKU2VlbXMgbW9yZSByb2J1c3QgdG8gbWUgdG8gdHJ5IHJlZ2FyZGxlc3Mgc2lu Y2UgdGhlIHRpbWVvdXQgaXMgc2hvcnQuCgo+IEl0J3MgdGhlIHNlcnZlciB1c2UgY2FzZSB3aXRo IHBlcnNpc3RlbnQgam9icyB0aGF0IHdvcnJpZXMgbWU7IGFuZCBJCj4gZXhwZWN0IHdpbGwgYmUg dXBzZXQgdW5sZXNzIHdlIGNhbiBkbyBhIHByZWVtcHQtdG8taWRsZSBiZWZvcmVoYW5kLiBBcmUK PiBzdXNwZW5kIGN5Y2xlcyBldmVuIGEgZmFjdG9yPyBQcm9iYWJseSBub3QsIGJ1dCB5b3UgbmV2 ZXIga25vdyB3aXRoCj4gdGhlcm1hbGQgYW5kIGhvc3QgbWlncmF0aW9uIHdoYXQgdGhleSBtYXkg Z2V0IHVwIHRvLgoKWWVhaCBkb24ndCBrbm93LgoKPj4+IFRoYXQncyBwcmV0dHkgbXVjaCBvdXIg YW5zd2VyIGluIGV2ZXJ5IGNhc2UsIHdlZGdlIGFuZCBob3BlIHRoZSB1c2VycyBnbwo+Pj4gYXdh eS4KPj4+Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgaWYgKGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUoaTkx NSwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9XQUlUX0xPQ0tF RCB8Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEk5MTVfV0FJVF9GT1Jf SURMRV9CT09TVCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSFogLyAx MCkpCj4+Pj4KPj4+PiBZb3UnbGwgcHJlc3VtYWJseSBjaGFuZ2UgSFogLyAxMCB0byB0aGF0IG5l dyBtYWNyby4KPj4+Cj4+PiBZdXAuCj4+Pgo+Pj4+PiAgICAgc3RhdGljIHZvaWQKPj4+Pj4gICAg IGk5MTVfZ2VtX2lkbGVfd29ya19oYW5kbGVyKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPj4+ Pj4gICAgIHsKPj4+Pj4gLSAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0K Pj4+Pj4gLSAgICAgICAgICAgICBjb250YWluZXJfb2Yod29yaywgdHlwZW9mKCpkZXZfcHJpdiks IGd0LmlkbGVfd29yay53b3JrKTsKPj4+Pj4gKyAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUgPQo+Pj4+PiArICAgICAgICAgICAgIGNvbnRhaW5lcl9vZih3b3JrLCB0eXBlb2YoKmk5 MTUpLCBndC5pZGxlX3dvcmsud29yayk7Cj4+Pj4+ICsgICAgIHR5cGVvZihpOTE1LT5ndCkgKmd0 ID0gJmk5MTUtPmd0Owo+Pj4+Cj4+Pj4gSSBhbSByZWFsbHkgbm90IHN1cmUgYWJvdXQgdGhlIHR5 cGVvZiBpZGlvbSBpbiBub3JtYWwgQyBjb2RlLiA6KCBJdAo+Pj4+IHNhdmVzIGEgbGl0dGxlIGJp dCBvZiB0eXBpbmcsIGFuZCBhIGxpdHRsZSBiaXQgb2YgY2h1cm4gaWYgdHlwZSBuYW1lCj4+Pj4g Y2hhbmdlcywgYnV0IGp1c3QgZmVlbHMgd2VpcmQgdG8gdXNlIGl0IHNvbWV3aGVyZSBhbmQgc29t ZXdoZXJlIG5vdC4KPj4+Cj4+PiBCdXQgdGhlbiB3ZSBoYXZlIHRvIG5hbWUgdGhpbmchIFdlJ3Jl IG5vdCBzb2xkIG9uIGd0OyBpdCBtZWFucyBxdWl0ZSBhCj4+PiBmZXcgZGlmZmVyZW50IHRoaW5n cyBhcm91bmQgdGhlIGJzcGVjLiBUaGlzIGJpdCBpcyBhY3R1YWxseSBwYXJ0IHRoYXQKPj4+IEkn bSBlYXJtYXJraW5nIGZvciBpOTE1X2dlbSBpdHNlbGYgKGhpZ2ggbGV2ZWwgaWRsZS9wb3dlci91 c2VyIG1hbmFnZW1lbnQpCj4+PiBhbmQgSSdtIGNvbnRlbXBsYXRpbmcgaTkxNV9ncHUgZm9yIHRo ZSBiaXRzIHRoYXQgYmVuZWF0aCB1cyBidXQgc3RpbGwgYQo+Pj4gbWFuYWdlbWVudCBsYXllciBv dmVyIGhhcmR3YXJlIChhbmQgaW50ZWxfZm9vIGZvciB0aGUgYml0cyB0aGF0IHRhbGsgdG8KPj4+ IGhhcmR3YXJlLiBNYXliZSB0aGF0IHRvbyB3aWxsIGNoYW5nZSBpZiB3ZSBjb21wbGV0ZWx5IHNw bGl0IG91dCBpbnRvCj4+PiBkaWZmZXJlbnQgbW9kdWxlcy4pCj4+Cj4+IFNvIHlvdSBjb3VsZCBo YXZlIGxlZnQgaXQgYXMgaXMgZm9yIG5vdyBhbmQgaGF2ZSBhIHNtYWxsZXIgZGlmZi4gQnV0Cj4+ IG9rYXkuLiBoYXZlIGl0IGlmIHlvdSBpbnNpc3QuCj4gCj4gTm8sIHlvdSd2ZSBzdGF0ZWQgb24g YSBmZXcgb2NjYXNpb25zIHRoYXQgeW91IGRvbid0IGxpa2UgZ3QtPlggc28gSSdsbAo+IGhhdmUg dG8gZmluZCBhIG5ldyBzdHJhdGVneSBhbmQgZml4dXAgcGF0Y2hlcyBhcyBJIHJlbWVtYmVyIHlv dXIKPiBkaXN0YXN0ZS4KCkkga25vdyBJIGRvbid0IGxpa2Ugc3ByaW5rbGluZyBvZiB0eXBlb2Yg dG8gZGVjbGFyZSBsb2NhbHMsIGJ1dCBkb24ndCAKcmVtZW1iZXIgaWYgSSBkaXNsaWtlZCBzb21l dGhpbmcgbW9yZS4gTm90IHN1cmUgd2hhdCB5b3VyICJubyIgcmVmZXJzIHRvIApub3cuIFRoYXQg eW91IGZlZWwgeW91IGhhZCB0byBkbyB0aGlzIGluIHRoaXMgcGF0Y2gsIG9yIHRoYXQgeW91IGRv bid0IAphY2NlcHQgbWluZSAiaGF2ZSBpdCBpZiB5b3UgaW5zaXN0Ij8KCj4gCj4gR2VuZXJhbCBw bGFuIGlzIHN0aWxsIHRvIHRyeSBhbmQgc3BsaXQgZHJtX2k5MTVfcHJpdmF0ZSBpbnRvIGk5MTVf Z2VtCj4gYW5kIGk5MTVfZ3B1IChmb3IgdXMgYXQgbGVhc3QpLgo+IAo+Pj4+PiAgICAgICAgIC8q Cj4+Pj4+IC0gICAgICAqIE5ldyByZXF1ZXN0IHJldGlyZWQgYWZ0ZXIgdGhpcyB3b3JrIGhhbmRs ZXIgc3RhcnRlZCwgZXh0ZW5kIGFjdGl2ZQo+Pj4+PiAtICAgICAgKiBwZXJpb2QgdW50aWwgbmV4 dCBpbnN0YW5jZSBvZiB0aGUgd29yay4KPj4+Pj4gKyAgICAgICogRmx1c2ggb3V0IHRoZSBsYXN0 IHVzZXIgY29udGV4dCwgbGVhdmluZyBvbmx5IHRoZSBwaW5uZWQKPj4+Pj4gKyAgICAgICoga2Vy bmVsIGNvbnRleHQgcmVzaWRlbnQuIFNob3VsZCBhbnl0aGluZyB1bmZvcnR1bmF0ZSBoYXBwZW4K Pj4+Pj4gKyAgICAgICogd2hpbGUgd2UgYXJlIGlkbGUgKHN1Y2ggYXMgdGhlIEdQVSBiZWluZyBw b3dlciBjeWNsZWQpLCBubyB1c2Vycwo+Pj4+PiArICAgICAgKiB3aWxsIGJlIGhhcm1lZC4KPj4+ Pj4gICAgICAgICAgKi8KPj4+Pj4gLSAgICAgaWYgKG5ld19yZXF1ZXN0c19zaW5jZV9sYXN0X3Jl dGlyZShkZXZfcHJpdikpCj4+Pj4+IC0gICAgICAgICAgICAgZ290byBvdXRfdW5sb2NrOwo+Pj4+ PiAtCj4+Pj4+IC0gICAgIF9faTkxNV9nZW1fcGFyayhkZXZfcHJpdik7Cj4+Pj4+ICsgICAgIGlm ICghZ3QtPmFjdGl2ZV9yZXF1ZXN0cyAmJiAhd29ya19wZW5kaW5nKCZndC0+aWRsZV93b3JrLndv cmspKSB7Cj4+Pj4KPj4+PiBDb3VsZCBoYXZlIGxlZnQgdGhlIG5ld19yZXF1ZXN0c19zaW5jZV9s YXN0X3JldGlyZSBmb3IgcmVhZGFiaWxpdHkuCj4+Pgo+Pj4gQXMgYWx3YXlzLCBpdCBjaGFuZ2Vk IHNldmVyYWwgdGltZXMuIEkgYWN0dWFsbHkgdGhpbmsgY29uc2lkZXJpbmcgdGhhdAo+Pj4gd2Ug cGxheSBnYW1lcyB3aXRoIGFjdGl2ZV9yZXF1ZXN0cywga2VlcGluZyB0aGF0IGluIHRoZSBvcGVu IGlzCj4+PiBpbXBvcnRhbnQuIH5vfgo+Pgo+PiBPay4KPj4KPj4+Pgo+Pj4+PiArICAgICAgICAg ICAgICsrZ3QtPmFjdGl2ZV9yZXF1ZXN0czsgLyogZG9uJ3QgcmVxdWV1ZSBpZGxlICovCj4+Pj4+ ICsKPj4+Pj4gKyAgICAgICAgICAgICBpZiAoIXN3aXRjaF90b19rZXJuZWxfY29udGV4dF9zeW5j KGk5MTUpKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICBkZXZfZXJyKGk5MTUtPmRybS5k ZXYsCj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gaWRsZSBl bmdpbmVzLCBkZWNsYXJpbmcgd2VkZ2VkIVxuIik7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICBHRU1fVFJBQ0VfRFVNUCgpOwo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgaTkxNV9nZW1f c2V0X3dlZGdlZChpOTE1KTsKPj4+Pj4gKyAgICAgICAgICAgICB9Cj4+Pj4+ICsgICAgICAgICAg ICAgaTkxNV9yZXRpcmVfcmVxdWVzdHMoaTkxNSk7Cj4+Pgo+Pj4+PiBAQCAtMzEyOCw3ICszMTIw LDYgQEAgaW50IGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUsCj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBlcnI7Cj4+Pj4+ICAg ICAKPj4+Pj4gICAgICAgICAgICAgICAgIGk5MTVfcmV0aXJlX3JlcXVlc3RzKGk5MTUpOwo+Pj4+ PiAtICAgICAgICAgICAgIEdFTV9CVUdfT04oaTkxNS0+Z3QuYWN0aXZlX3JlcXVlc3RzKTsKPj4+ Pgo+Pj4+IEJlbG9uZ3MgdG8gdGhpcyBwYXRjaD8KPj4+Cj4+PiBZZXMuIFNlZSB0aGUgYWJvdmUg Y2h1bmsuCj4+Cj4+IFRoZSBpZGxlIHdvcmsgaGFuZGxlcj8gTW9yZSBoYW5kIGhvbGRpbmcgcmVx dWlyZWQgSSdtIGFmcmFpZC4KPiAKPiBPaywgaW4gdGhlIGlkbGUgd29yaywgd2UgYnVtcCBhY3Rp dmVfcmVxdWVzdHMgYmVmb3JlIGNhbGxpbmcKPiBpOTE1X2dlbV93YWl0X2Zvcl9pZGxlKCkgdG8g cHJldmVudCBhY3RpdmVfcmVxdWVzdHMgPT0gMCBoZXJlLiBXZQo+IGludGVudGlvbmFsbHkgaGl0 IHRoZSBHRU1fQlVHX09OLCBpbiBvcmRlciB0byBwcmV2ZW50IHJlcXVldWluZyB0aGUgaWRsZQo+ IHdvcmsgaGFuZGxlciBieSBlbWl0dGluZyB0aGUgcmVxdWVzdCB0byBzd2l0Y2ggdG8ga2VybmVs IGNvbnRleHQuCgpXZWxsIGRvaC4uIHNlZW1zIGxpa2UgSSBoYWQgYSBzbWFsbCBzdGFjayBvdmVy Zmxvdy4gRGlkbid0IHNlZSB0aGUgd2FpdCAKc2luY2UgaXQgaXMgImhpZGRlbiIgaW4gc3dpdGNo X3RvX2tlcm5lbF9jb250ZXh0X3N5bmMuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==