From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support Date: Thu, 22 Jun 2017 10:25:49 +0200 Message-ID: <2895576.2l0uxY0YQ7@phil> References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> <594B79A4.1000509@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <594B79A4.1000509@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gRG9ubmVyc3RhZywgMjIuIEp1bmkgMjAxNywgMTY6MDI6NDQgQ0VTVCBzY2hyaWViIE1hcmsg eWFvOgo+IE9uIDIwMTflubQwNuaciDIy5pelIDE1OjMxLCBIZWlrbyBTdHVlYm5lciB3cm90ZToK PiA+PiArCj4gPj4gPisvKioKPiA+PiA+KyAqIHN0cnVjdCByb2NrY2hpcF9oZG1pX2NoaXBfZGF0 YSAtIHNwbGl0ZSB0aGUgZ3JmIHNldHRpbmcgb2Yga2luZCBvZiBjaGlwcwo+ID4+ID4rICogQGxj ZHNlbF9ncmZfcmVnOiBncmYgcmVnaXN0ZXIgb2Zmc2V0IG9mIGxjZGMgc2VsZWN0Cj4gPj4gPisg KiBAbGNkc2VsX2JpZzogcmVnIHZhbHVlIG9mIHNlbGVjdGluZyB2b3AgYmlnIGZvciBIRE1JCj4g Pj4gPisgKiBAbGNkc2VsX2xpdDogcmVnIHZhbHVlIG9mIHNlbGVjdGluZyB2b3AgbGl0dGxlIGZv ciBIRE1JCj4gPj4gPisgKi8KPiA+PiA+K3N0cnVjdCByb2NrY2hpcF9oZG1pX2NoaXBfZGF0YSB7 Cj4gPj4gPisJdTMyCWxjZHNlbF9ncmZfcmVnOwo+ID4gSG93IGRvIHlvdSBwbGFuIG9uIGhhbmRs aW5nIHRoZSByazMzNjggKHdpdGggb25seSBvbmUgVk9QIGFuZCB0aHVzCj4gPiBubyBzZWxlY3Rp b24gaGFwcGVuaW5nKT8gSSdkIGp1c3QgbWFrZSB0aGUgYWJvdmUgYW4gaW50LCBzbyB3ZSBjb3Vs ZAo+ID4gc2V0IGl0IHRvIC0xIGZvciB0aGF0IGNhc2UuICh2YWx1ZSAwIGlzIGFmdGVyIGFsbCBh IHZhbGlkIHJlZykuCj4gCj4gSXQncyBhIHByb2JsZW0gaGFuZGxpbmcgb24gcmszMzY4LCB1c2lu ZyAtMSB0byBqdWRnZSBtZWFucyB0aGF0IHdlIG5lZWQKPiBpbml0aWFsIHRoZSBsY2RzZWxfZ3Jm X3JlZyB0byAtMSBvbiByazMzNjggcGxhdGZvcm0sIHdlIG5lZWQgYWx3YXlzIGFkZCBhIHBsYXRm b3JtCj4gZGF0YSB0byBoYW5kbGUgaXQsIHNlZW1zIG5vdCBnb29kIGVub3VnaC4KPiAKPiBTaW5j ZSB0aGUgaGRtaSBjaGlwIGRhdGEgb25seSB1c2UgZm9yIHZvcCBzZWxlY3Rpb24sIG1heWJlIHdl IGNhbiBqdWRnZSB3aXRoCj4gY2hlY2tpbmcgaGRtaS0+Y2hpcF9kYXRhID09IE5VTEwgZm9yIHRo ZSBjYXNlLgoKeWVhaCwgdGhhdCBjb3VsZCB3b3JrIGFzIHdlbGwgLi4uIGFzIGxvbmcgYXMgdGhl IGdyZi12b3Atc2VsZWN0IGlzIHRoZSBvbmx5IGNoaXAtZGF0YQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 22 Jun 2017 10:25:49 +0200 Subject: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support In-Reply-To: <594B79A4.1000509@rock-chips.com> References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> <594B79A4.1000509@rock-chips.com> Message-ID: <2895576.2l0uxY0YQ7@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, 22. Juni 2017, 16:02:44 CEST schrieb Mark yao: > On 2017?06?22? 15:31, Heiko Stuebner wrote: > >> + > >> >+/** > >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips > >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select > >> >+ * @lcdsel_big: reg value of selecting vop big for HDMI > >> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI > >> >+ */ > >> >+struct rockchip_hdmi_chip_data { > >> >+ u32 lcdsel_grf_reg; > > How do you plan on handling the rk3368 (with only one VOP and thus > > no selection happening)? I'd just make the above an int, so we could > > set it to -1 for that case. (value 0 is after all a valid reg). > > It's a problem handling on rk3368, using -1 to judge means that we need > initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform > data to handle it, seems not good enough. > > Since the hdmi chip data only use for vop selection, maybe we can judge with > checking hdmi->chip_data == NULL for the case. yeah, that could work as well ... as long as the grf-vop-select is the only chip-data From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdFVI0I convert rfc822-to-8bit (ORCPT ); Thu, 22 Jun 2017 04:26:08 -0400 Received: from gloria.sntech.de ([95.129.55.99]:47954 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbdFVI0F (ORCPT ); Thu, 22 Jun 2017 04:26:05 -0400 From: Heiko Stuebner To: Mark yao Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support Date: Thu, 22 Jun 2017 10:25:49 +0200 Message-ID: <2895576.2l0uxY0YQ7@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <594B79A4.1000509@rock-chips.com> References: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> <1751555.73cFbViMXZ@phil> <594B79A4.1000509@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 22. Juni 2017, 16:02:44 CEST schrieb Mark yao: > On 2017年06月22日 15:31, Heiko Stuebner wrote: > >> + > >> >+/** > >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips > >> >+ * @lcdsel_grf_reg: grf register offset of lcdc select > >> >+ * @lcdsel_big: reg value of selecting vop big for HDMI > >> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI > >> >+ */ > >> >+struct rockchip_hdmi_chip_data { > >> >+ u32 lcdsel_grf_reg; > > How do you plan on handling the rk3368 (with only one VOP and thus > > no selection happening)? I'd just make the above an int, so we could > > set it to -1 for that case. (value 0 is after all a valid reg). > > It's a problem handling on rk3368, using -1 to judge means that we need > initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform > data to handle it, seems not good enough. > > Since the hdmi chip data only use for vop selection, maybe we can judge with > checking hdmi->chip_data == NULL for the case. yeah, that could work as well ... as long as the grf-vop-select is the only chip-data