Re: [dpdk-dev] [PATCH v4] lib/power: remove set env deprecation notice

[Thomas Monjalon <thomas@monjalon.net>]

27/10/2020 14:24, David Hunt:
> Remove notice announcing an already-implemented change.
> 
> In 19.05, rte_power_set_env was changed to return -1 in cases where
> the envorinment was already set up, and for the same release, a
> deprecation notice was added for the following commit:
> 'commit 5a5f3178d4a8 ("power: return error when environment already set")'
> This patch removes that notice.
> 
> The API change was tested by calling rte_power_set_env twice. The first
> call succeeded, and the second call failed, as expected.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> 
> ---
> 
> v1 initial version (with typo in the title)
> v2 fix typo but forgot --in-reply-to
> v3 add -in-reply-to
> v4 add in version info, and cc stable in case it needs to be backported
> 
> Note: CC'ing stable in case the deprecation notice should also be removed
> from 19.11. It looks to me like the patch making the change and the patch
> adding the notice were both added in 19.11, so the notice is no longer
> needed in that verion. I didn't add a Fixes line to this patch as I believe
> the notice was correct, just adding both fix and notice in the same version
> was not strictly the right thing to have done at the time.

The Fixes: line must reference the commit which did the API change
without removing the notice.

Cc: stable@dpdk.org must be below the Fixes line.