From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] ether: fix incorrect stats query for lowest xstat id
Date: Tue, 06 Feb 2018 18:46:14 +0100 [thread overview]
Message-ID: <2897371.3Us8B8FbjR@xps> (raw)
In-Reply-To: <20180206160659.87323-1-bruce.richardson@intel.com>
06/02/2018 17:06, Bruce Richardson:
> When querying either the name or the value of a stat using the xstats
> APIs, a check is done to see if the regular stats API or the xstats APIs
> for the driver need to be used. However, the id of the stat requested is
> checked to see if it is greater than the number of basic stats, rather
> than checking for greater-or-equal, meaning that the xstat with the lowest
> id gets incorrectly treated as a basic stat.
>
> This problem manifests itself when you call proc_info using "--xstats-id"
> for the first xstat, you get no name of the stat printed, and a random(ish)
> stat value.
>
> Fixes: 4773152f850b ("ethdev: optimize xstats by ids APIs")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
It looks like the stats functions are the most reworked and fixed.
It is a no-end story. According to git statistics, it is probably
the most complicate code of DPDK :)
I am thinking about being more conservative and do not accept any
new change in these rocket science functions ;)
prev parent reply other threads:[~2018-02-06 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 16:06 [PATCH] ether: fix incorrect stats query for lowest xstat id Bruce Richardson
2018-02-06 17:42 ` Ferruh Yigit
2018-02-06 17:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2897371.3Us8B8FbjR@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.