From: Martin Steigerwald <martin@lichtvoll.de>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
Jens Axboe <axboe@kernel.dk>,
Michael Schmitz <schmitzmic@gmail.com>
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, hch@lst.de,
stable@vger.kernel.org, "R.T.Dickinson" <rtd2@xtra.co.nz>,
Darren Stevens <darren@stevens-zone.net>,
mad skateman <madskateman@gmail.com>,
Christian Zigotzky <info@xenosoft.de>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: bugfix for Amiga partition overflow check patch
Date: Tue, 04 Jul 2023 09:28:02 +0200 [thread overview]
Message-ID: <2897789.e9J7NaK4W3@lichtvoll.de> (raw)
In-Reply-To: <11cacce5-8252-c65f-0d41-8d7ad1c17d91@gmail.com>
Michael Schmitz - 04.07.23, 07:58:13 CEST:
> > OK, so using "-1" as an end-of-disk partition marker is fine, but it
> > was just the partition size recorded in Christian's RDB that was
> > incorrect, correct?
> No, the partition size in the RDB was correct (valid, end cylinder
> before end of disk). The partition size seen by user space tools when
> running the old kernels was incorrect. That lead to the filesystem
> size exceeding the partition size, which only came to light once the
> overflow fixes had gone in.
>
> I know it does sound like semantic sophism, but we have to be clear
> that what the user put in the partition block is definite. I haven't
> had much luck with heuristics in kernel code lately...
Now I finally get this issue, I think. Thanks for this explanation.
I think something like this would do good in the patch description.
Best,
--
Martin
prev parent reply other threads:[~2023-07-04 7:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 2:35 [PATCH] block: bugfix for Amiga partition overflow check patch Michael Schmitz
2023-07-01 6:40 ` Christian Zigotzky
2023-07-01 8:11 ` Michael Schmitz
2023-07-01 9:48 ` Christian Zigotzky
2023-07-02 2:17 ` Michael Schmitz
2023-07-02 3:45 ` Michael Schmitz
2023-07-02 4:37 ` Christian Zigotzky
2023-07-02 7:55 ` Martin Steigerwald
2023-07-02 8:56 ` Christian Zigotzky
2023-07-02 9:34 ` Christian Zigotzky
2023-07-02 9:51 ` John Paul Adrian Glaubitz
2023-07-02 10:34 ` Martin Steigerwald
2023-07-03 1:57 ` Michael Schmitz
2023-07-02 20:22 ` Michael Schmitz
2023-07-03 7:05 ` Martin Steigerwald
2023-07-03 14:19 ` Christian Zigotzky
2023-07-03 14:59 ` Christian Zigotzky
2023-07-03 21:24 ` Michael Schmitz
2023-07-03 21:27 ` Jens Axboe
2023-07-03 22:43 ` Michael Schmitz
2023-07-04 5:06 ` John Paul Adrian Glaubitz
2023-07-04 5:44 ` Michael Schmitz
2023-07-04 5:48 ` John Paul Adrian Glaubitz
2023-07-04 5:58 ` Michael Schmitz
2023-07-04 7:28 ` Martin Steigerwald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2897789.e9J7NaK4W3@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=axboe@kernel.dk \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hch@lst.de \
--cc=info@xenosoft.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=madskateman@gmail.com \
--cc=rtd2@xtra.co.nz \
--cc=schmitzmic@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.