From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 24 Oct 2012 20:23:19 +0200 (CEST) Received: from smtp-vbr8.xs4all.nl ([194.109.24.28]:4367 "EHLO smtp-vbr8.xs4all.nl" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6825702Ab2JXSXSFi4kI (ORCPT ); Wed, 24 Oct 2012 20:23:18 +0200 Received: from starbug-2.trinair2002 (dhcp-089-098-069-120.chello.nl [89.98.69.120]) (authenticated bits=0) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id q9OIMQWr040413; Wed, 24 Oct 2012 20:22:26 +0200 (CEST) (envelope-from maarten@treewalker.org) Received: from hyperion.localnet (hyperion.trinair2002 [192.168.0.43]) by starbug-2.trinair2002 (Postfix) with ESMTP id 0688630AA; Wed, 24 Oct 2012 20:22:26 +0200 (CEST) From: Maarten ter Huurne To: Florian Fainelli Cc: linux-mips@linux-mips.org, Antony Pavlov , Ralf Baechle , Lars-Peter Clausen Subject: Re: [RFC 11/13] MIPS: JZ4750D: Add Kbuild files Date: Wed, 24 Oct 2012 20:15:37 +0200 Message-ID: <2898753.opXRKuz76b@hyperion> User-Agent: KMail/4.9.2 (Linux/3.4.11-2.16-desktop; KDE/4.9.2; x86_64; ; ) In-Reply-To: <6315819.WnqMkxcSqV@bender> References: <1351014241-3207-1-git-send-email-antonynpavlov@gmail.com> <4796718.WhuB0k6pfC@hyperion> <6315819.WnqMkxcSqV@bender> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Virus-Scanned: by XS4ALL Virus Scanner X-archive-position: 34772 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: maarten@treewalker.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On Wednesday 24 October 2012 19:43:25 Florian Fainelli wrote: > On Wednesday 24 October 2012 18:16:35 Maarten ter Huurne wrote: > > On Tuesday 23 October 2012 21:43:59 Antony Pavlov wrote: > > > Add the Kbuild files for the JZ4750D architecture and adds JZ4750D > > > support to the MIPS Kbuild files. > > > > [snip] > > > > > diff --git a/arch/mips/jz4750d/Platform b/arch/mips/jz4750d/Platform > > > new file mode 100644 > > > index 0000000..2e4e050 > > > --- /dev/null > > > +++ b/arch/mips/jz4750d/Platform > > > @@ -0,0 +1,3 @@ > > > +platform-$(CONFIG_MACH_JZ4750D) += jz4750d/ > > > +cflags-$(CONFIG_MACH_JZ4750D) += > > > -I$(srctree)/arch/mips/include/asm/mach-jz4750d > > > +load-$(CONFIG_MACH_JZ4750D) += 0xffffffff80010000 > > > > What is the purpose of padding the load address to 64 bits? > > > > The reason I'm asking is that we encountered a bug with that when > > creating a u-boot image on a 32-bit host machine: the mkimage tool will > > only parse the first 8 hex digits and then inserts the wrong load > > address into the uImage. > > AFAIR u-boot's mkimage expects 32-bits quantities as a load address, so I > would not be surprised that using this line as-is as an input parameter > to mkimage does not give yout the expected result. The actual uImage format supports only 32-bit addresses, but mkimage is inconsistent in its handling of 64-bit addresses: if the tool is compiled for x86_64 it parses all 16 hex digits and uses the lower 32 bits, but if it is compiled for x86 it parses only the first 8 hex digits and the resulting image won't boot. There is no "uImage" target for MIPS in the mainline kernel; we added our own and it indeed passes $(VMLINUX_LOAD_ADDRESS) to mkimage as-is on the command line. Since Ralf indicated that there are good reasons for sign extending the address, I think I'll have to change how it is passed to mkimage. Bye, Maarten