Re: [PATCH] mk: Make XEN_PMD build in combined library mode

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-12-02 13:38, Christian Ehrhardt:
> Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was
> enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html).
> Now the underlying issue is rather simple, the xen code needs libxenstore.
> But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was
> disabled.
> While it is correct to create the DPDK sublib linking only in the
> RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked
> libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled.
[...]
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -113,6 +113,7 @@ endif # ! CONFIG_RTE_BUILD_SHARED_LIBS
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD)      += -lz
>  
>  _LDLIBS-y += --start-group
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT)    += -lxenstore

Why is it moved after --start-group and not above as other dependencies?

>  ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)