From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AC9F5393 for ; Fri, 3 Mar 2023 11:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677843553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v1Ct/6nINkmWZSFMigoxMFMstImpmSCqjjI/pBizmA0=; b=WSJ9KZpK4vih8azuewSkt/m8tva5TYHJ7JGhLYzj3q9hsBZ2evR073WBJq8FRuo3AE6YaK eSIK8x4Ft2Xa1PQunq3PPPAlKj+XoLmVobSEgQ+TnpTvtdKzypO6hOGYzTGY3bRLOoDUY7 HPclpe5BwkKQH584WwUMLdQP8moISOw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-552-pYbkK8ZbNMmm0e2ehfTHXA-1; Fri, 03 Mar 2023 06:39:11 -0500 X-MC-Unique: pYbkK8ZbNMmm0e2ehfTHXA-1 Received: by mail-wm1-f71.google.com with SMTP id j6-20020a05600c1c0600b003eaf882cb85so870051wms.9 for ; Fri, 03 Mar 2023 03:39:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677843550; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v1Ct/6nINkmWZSFMigoxMFMstImpmSCqjjI/pBizmA0=; b=tM6pyuXMc7ca7cXsPHaAv/ZsYJLnvwnKNjYFIVqXgGFa8urGB8F+JIeMSy9J6Yr1su 7owX4xfNOfZ0G/04ZKnB1MSwJFyjHhYsyONEvqndehqfyMOLlQRbh7/V/ROjyWYzCnM+ X/EiS5dsEy5jK8xMxHsogtlBpAIVq2gIgkytNIaOuJQLC3SitGtPsxb2FmYUpq7g7qKB ZMPINq5ib6bCBEOCOzOD4EkjahZ/WDXrM0UIWRNLWbfdVBbsaoVsX1Vs+GDPr+jC/aPm ZO/gwGk0Lkj2bwuz3YTCq+Jmd2ifO8nBBmMyQ5jxPHdsJB+eD1VD1sc2YAxsCHqQD9zd M5jg== X-Gm-Message-State: AO0yUKW2md558J+IhmOvGUb38yHX1IaLRbdRpFeyB0lEz2CWSD3XgHc5 6juZDELo+5oC20XKVixyUTsQKEPADdoyyquXZgmcu0H+CBGVEqKXO+43kFY1oZHkiiWY3YUoI+m LajH9jKvzeQErP7b7Tg== X-Received: by 2002:a05:600c:3b07:b0:3eb:2e2a:be82 with SMTP id m7-20020a05600c3b0700b003eb2e2abe82mr1246726wms.2.1677843550668; Fri, 03 Mar 2023 03:39:10 -0800 (PST) X-Google-Smtp-Source: AK7set9mwcWeiYEjlmyu4x2ILE7IqBBjOngusHgtCAMB0AGXHzaXoDMdecgdiEJ4F2mFuYU5V0UiRg== X-Received: by 2002:a05:600c:3b07:b0:3eb:2e2a:be82 with SMTP id m7-20020a05600c3b0700b003eb2e2abe82mr1246704wms.2.1677843550405; Fri, 03 Mar 2023 03:39:10 -0800 (PST) Received: from gerbillo.redhat.com (146-241-121-8.dyn.eolo.it. [146.241.121.8]) by smtp.gmail.com with ESMTPSA id s8-20020a7bc388000000b003eb2e685c7dsm5725689wmj.9.2023.03.03.03.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 03:39:09 -0800 (PST) Message-ID: <28afc90c1b8b51a36ced5b6026d1a64aeb7c0b14.camel@redhat.com> Subject: Re: [PATCH 6.1 00/42] 6.1.15-rc1 review From: Paolo Abeni To: Greg Kroah-Hartman , Naresh Kamboju Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, mptcp@lists.linux.dev, Florian Westphal , Mat Martineau , Matthieu Baerts , Anders Roxell Date: Fri, 03 Mar 2023 12:39:07 +0100 In-Reply-To: References: <20230301180657.003689969@linuxfoundation.org> <9586d0f99e27483b600d8eb3b5c6635b50905d82.camel@redhat.com> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2023-03-03 at 10:23 +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 03, 2023 at 02:34:05PM +0530, Naresh Kamboju wrote: > > On Fri, 3 Mar 2023 at 13:34, Paolo Abeni wrote: > > > I read the above as you are running self-tests from 6.2.1 on top of a= n > > > older (6.1) kernel. Is that correct? > >=20 > > correct. > >=20 > > > If so failures are expected; >=20 > Shouldn't the test be able to know that "new features" are not present > and properly skip the test for when that happens? =C2=A0 I was not aware that running self-tests on older kernels is a common practice. I'm surprised that hits mptcp specifically. I think most networking tests have the same problem. Additionally, some self-tests check for known bugs/regressions. Running them on older kernel will cause real trouble, and checking for bug presence in the running kernel would be problematic at best, I think. > Otherwise this feels > like a problem going forward as no one will know if this feature can be > used or not (assuming it is a new feature and not just a functional > change.) I don't understand this later part, could you please re-phrase? Users should look at release notes and/or official documentation to know the supported features, not to self-tests output ?!? Thanks! Paolo p.s. for some reasons I did not receive the previous replies, I had to fetch the conversation from the ML archives.