From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Koenig, Christian" Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed Date: Thu, 3 Jan 2019 15:57:50 +0000 Message-ID: <28b7eafd-3473-1480-e1b4-cfbd995f5fe3@amd.com> References: <1544686892-32619-1-git-send-email-Xiangliang.Yu@amd.com> <71d6a5f3-51dd-9e02-a99f-a4acb3c2ce35@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <8A33AD74481FD94B98714491E7785E82-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yu, Xiangliang" , "Xu, Feifei" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Deucher, Alexander" PiBGb3IgVmVnYTEwLCBjb3VsZCB5b3UgZXhwbGFpbiB3aHkgaXQgYmxvY2sgb2xkZXIgdmVyc2lv biBmdz8NCkknbSBub3QgdmVyeSBmYW1pbGlhciB3aXRoIHRoZSBQU1AsIHNvIEkgZG9uJ3Qga25v dyB3aGF0IGV4YWN0bHkgaXMgDQpnb2luZyB3cm9uZyBoZXJlLg0KDQpTeW1wdG9tcyBhcmUgdGhh dCB3ZSBnZXQgdGhlIGZvbGxvd2luZyBpbiBkbWVzZzoNCj4gSmFuIDAzIDE1OjU1OjE3IGFiZWwg a2VybmVsOiBbZHJtXSBQU1AgbG9hZGluZyBWQ0UgZmlybXdhcmUNCj4gSmFuIDAzIDE1OjU1OjE3 IGFiZWwga2VybmVsOiBbZHJtXSByZXNlcnZlIDB4NDAwMDAwIGZyb20gMHhmNDAwYzAwMDAwIA0K PiBmb3IgUFNQIFRNUiBTSVpFDQo+IEphbiAwMyAxNTo1NToxNyBhYmVsIGtlcm5lbDogW2RybTpw c3BfY21kX3N1Ym1pdF9idWYgW2FtZGdwdV1dICpFUlJPUiogDQo+IHBzcCBjb21tYW5kIGZhaWxl ZCBhbmQgcmVzcG9uc2Ugc3RhdHVzIGlzICgxKQ0KPiBKYW4gMDMgMTU6NTU6MTcgYWJlbCBrZXJu ZWw6IFtkcm06cHNwX2h3X2luaXQgW2FtZGdwdV1dICpFUlJPUiogUFNQIA0KPiBmaXJtd2FyZSBs b2FkaW5nIGZhaWxlZA0KPiBKYW4gMDMgMTU6NTU6MTcgYWJlbCBrZXJuZWw6IFtkcm06YW1kZ3B1 X2RldmljZV9md19sb2FkaW5nIFthbWRncHVdXSANCj4gKkVSUk9SKiBod19pbml0IG9mIElQIGJs b2NrIDxwc3A+IGZhaWxlZCAtMjINCj4gSmFuIDAzIDE1OjU1OjE3IGFiZWwga2VybmVsOiBhbWRn cHUgMDAwMDo0MzowMC4wOiANCj4gYW1kZ3B1X2RldmljZV9pcF9pbml0IGZhaWxlZA0KPiBKYW4g MDMgMTU6NTU6MTcgYWJlbCBrZXJuZWw6IGFtZGdwdSAwMDAwOjQzOjAwLjA6IEZhdGFsIGVycm9y IGR1cmluZyANCj4gR1BVIGluaXQNCg0KSSB0aGluayB0aGUgY29kZSB3YXMgcHVycG9zZWx5IGln bm9yaW5nIHNvbWUgcmV0dXJuIHN0YXR1cyBiZWNhdXNlIHRoZSANCmNvbW1hbmQgd2Fzbid0IGF2 YWlsYWJsZSBvbiBvbGRlciBmdyBnZW5lcmF0aW9ucy4NCg0KTm93IHRoYXQgd2UgYmFpbCBvdXQg b24gZXZlcnkgbm9uIHplcm8gcmV0dXJuIGNvZGUgdGhhdCBmYWlscyB3aGVuIHlvdSANCnRyeSB0 byB1c2UgdGhlIG9sZGVyIFBTUCBmaXJtd2FyZSBvbiBWZWdhMTAuDQoNCkFueXdheSBicmVha2lu ZyBvbGRlciBmdyB2ZXJzaW9ucyBpcyBub3Qgc29tZXRoaW5nIHdlIGNhbiBkbywgc28gd2UgbmVl ZCANCnRvIGVpdGhlciBmaXggb3IgcmV2ZXJ0IHRoYXQgQVNBUCBvciBlbmQgdXNlcnMgd2lsbCBz dGFydCB0byBjb21wbGFpbi4NCg0KQW55IGlkZWEgaG93IHRvIGludmVzdGlnYXRlIGZ1cnRoZXI/ DQoNCkNocmlzdGlhbi4NCg0KQW0gMDMuMDEuMTkgdW0gMTY6MjEgc2NocmllYiBZdSwgWGlhbmds aWFuZzoNCj4gWEdNSSBjb21tYW5kIHdpbGwgbm90IGxvYWQgdWNvZGUsIHNvIGl0IGNhbid0IGZp bmQgdGhlIGNvbW1hbmQgZmFpbGVkIGlmIGNoZWNrIHVjb2RlIGF0IGZpcnN0Lg0KPiBGb3IgY29k ZSBsb2dpYywgc2hvdWxkIGNoZWNrIHJlc3BvbnNlIHN0YXR1cyB0byBzZWUgaWYgY29tbWFuZCBj b21wbGV0ZSBzdWNjZXNzZnVsbHkgYXQgZmlyc3QuDQo+IEZvciBWZWdhMTAsIGNvdWxkIHlvdSBl eHBsYWluIHdoeSBpdCBibG9jayBvbGRlciB2ZXJzaW9uIGZ3Pw0KPg0KPg0KPiAtLS0tLU9yaWdp bmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBDaHJpc3RpYW4gS8O2bmlnIDxja29lbmlnLmxlaWNo dHp1bWVya2VuQGdtYWlsLmNvbT4NCj4gU2VudDogVGh1cnNkYXksIEphbnVhcnkgMDMsIDIwMTkg MTE6MDAgUE0NCj4gVG86IFh1LCBGZWlmZWkgPEZlaWZlaS5YdUBhbWQuY29tPjsgWXUsIFhpYW5n bGlhbmcgPFhpYW5nbGlhbmcuWXVAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnOyBEZXVjaGVyLCBBbGV4YW5kZXIgPEFsZXhhbmRlci5EZXVjaGVyQGFtZC5jb20+DQo+IFN1 YmplY3Q6IFJlOiBbUEFUQ0ggMi8yXSBkcm0vYW1kZ3B1L3BzcDogRml4IGNhbid0IGRldGVjdCBw c3AgSU5WT0tFIGNvbW1hbmQgZmFpbGVkDQo+DQo+IEhpIGd1eXMsDQo+DQo+IHRoaXMgcGF0Y2gg YnJva2UgbG9hZGluZyBvbGRlciB2ZXJzaW9ucyBvZiBQU1AgZmlybXdhcmUgb24gVmVnYTEwLg0K Pg0KPiBXaGF0IGV4YWN0bHkgaXMgdGhlIGJhY2tncm91bmQgaGVyZT8gRS5nLiB3aHkgZG8gd2Ug bmVlZCBpdD8gQW5kIGNhbiB3ZSByZXZlcnQgaXQgQVNBUD8NCj4NCj4gVGhhbmtzLA0KPiBDaHJp c3RpYW4uDQo+DQo+IEFtIDE4LjEyLjE4IHVtIDAzOjQ1IHNjaHJpZWIgWHUsIEZlaWZlaToNCj4+ IFJldmlld2VkLWJ5OiBGZWlmZWkgWHUgPEZlaWZlaS5YdUBhbWQuY29tPg0KPj4NCj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBhbWQtZ2Z4IDxhbWQtZ2Z4LWJvdW5jZXNA bGlzdHMuZnJlZWRlc2t0b3Aub3JnPiBPbiBCZWhhbGYgT2YNCj4+IFhpYW5nbGlhbmcgWXUNCj4+ IFNlbnQ6IFRodXJzZGF5LCBEZWNlbWJlciAxMywgMjAxOCAzOjQyIFBNDQo+PiBUbzogYW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4+IENjOiBZdSwgWGlhbmdsaWFuZyA8WGlhbmdsaWFu Zy5ZdUBhbWQuY29tPg0KPj4gU3ViamVjdDogW1BBVENIIDIvMl0gZHJtL2FtZGdwdS9wc3A6IEZp eCBjYW4ndCBkZXRlY3QgcHNwIElOVk9LRQ0KPj4gY29tbWFuZCBmYWlsZWQNCj4+DQo+PiBUaGVy ZSBpc24ndCB1Y29kZSB3aGVuIGV4ZWN1dGluZyBJTlZPS0UgY29tbWFuZCwgc28gY3VycmVudCBj b2RlIGNhbid0IGNoZWNrIHRoZSBmYWlsdXJlIG9mIElOVk9LRSBjb21tYW5kLg0KPj4NCj4+IFJl bW92ZSB0aGUgdWNvZGUgY2hlY2suDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogWGlhbmdsaWFuZyBZ dSA8WGlhbmdsaWFuZy5ZdUBhbWQuY29tPg0KPj4gLS0tDQo+PiAgICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfcHNwLmMgfCAxMSArKysrKysrLS0tLQ0KPj4gICAgMSBmaWxlIGNo YW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jDQo+PiBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wc3AuYw0KPj4gaW5kZXggMmYxMjZlYTcuLjdmNWNl MzcgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcHNw LmMNCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wc3AuYw0KPj4g QEAgLTE0MCwxMCArMTQwLDEzIEBAIHBzcF9jbWRfc3VibWl0X2J1ZihzdHJ1Y3QgcHNwX2NvbnRl eHQgKnBzcCwNCj4+ICAgIAl3aGlsZSAoKigodW5zaWduZWQgaW50ICopcHNwLT5mZW5jZV9idWYp ICE9IGluZGV4KQ0KPj4gICAgCQltc2xlZXAoMSk7DQo+PiAgICANCj4+IC0JLyogdGhlIHN0YXR1 cyBmaWVsZCBtdXN0IGJlIDAgYWZ0ZXIgRlcgaXMgbG9hZGVkICovDQo+PiAtCWlmICh1Y29kZSAm JiBwc3AtPmNtZF9idWZfbWVtLT5yZXNwLnN0YXR1cykgew0KPj4gLQkJRFJNX0VSUk9SKCJmYWls ZWQgbG9hZGluZyB3aXRoIHN0YXR1cyAoJWQpIGFuZCB1Y29kZSBpZCAoJWQpXG4iLA0KPj4gLQkJ CSAgcHNwLT5jbWRfYnVmX21lbS0+cmVzcC5zdGF0dXMsIHVjb2RlLT51Y29kZV9pZCk7DQo+PiAr CS8qIHRoZSBzdGF0dXMgZmllbGQgbXVzdCBiZSAwIGFmdGVyIHBzcCBjb21tYW5kIGNvbXBsZXRp b24gKi8NCj4+ICsJaWYgKHBzcC0+Y21kX2J1Zl9tZW0tPnJlc3Auc3RhdHVzKSB7DQo+PiArCQlp ZiAodWNvZGUpDQo+PiArCQkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gbG9hZCB1Y29kZSBpZCAoJWQp ICIsDQo+PiArCQkJCSAgdWNvZGUtPnVjb2RlX2lkKTsNCj4+ICsJCURSTV9FUlJPUigicHNwIGNv bW1hbmQgZmFpbGVkIGFuZCByZXNwb25zZSBzdGF0dXMgaXMgKCVkKVxuIiwNCj4+ICsJCQkgIHBz cC0+Y21kX2J1Zl9tZW0tPnJlc3Auc3RhdHVzKTsNCj4+ICAgIAkJcmV0dXJuIC1FSU5WQUw7DQo+ PiAgICAJfQ0KPj4gICAgDQo+PiAtLQ0KPj4gMi43LjQNCj4+DQo+PiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QN Cj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+PiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngNCj4+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdA0K Pj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA0KDQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2FtZC1nZngK